Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:94518
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.215.54 as permitted sender)
MIME-Version: 1.0
References: <CAPwsocEihGOWC5_KX_FFe36dKTdSob0FFJUKuQW+u53QyeqgsQ@mail.gmail.com>
In-Reply-To: <CAPwsocEihGOWC5_KX_FFe36dKTdSob0FFJUKuQW+u53QyeqgsQ@mail.gmail.com>
Date: Sat, 16 Jul 2016 00:17:19 +0000
Message-ID: <CAPwsocEL-CV1WrbqyADdGZQA8WjY3Wye4eSdL6NN0E_+b3NsOQ@mail.gmail.com>
To: internals@lists.php.net
Content-Type: multipart/alternative; boundary=001a113fc21a10ad320537b5a9cb
Subject: Re: [RFC][VOTE] RNG fixes
From: leight@gmail.com (Leigh)

--001a113fc21a10ad320537b5a9cb
Content-Type: text/plain; charset=UTF-8

On Thu, 7 Jul 2016 at 11:39 Leigh <leight@gmail.com> wrote:

> As the discussion thread has been quiet for a while, moving this RFC to
> voting.
>
> https://wiki.php.net/rfc/rng_fixes
>
> https://github.com/php/php-src/pull/1986


Votes are now closed. Results as follows:

* 19-5 - Fix mt_rand() implementation
* 21-4 - Alias rand() to mt_rand()
* 25-0 - Fix RAND_RANGE()
* 23-0 - Replace insecure uses of php_rand() with php_random_bytes()
* 24-0 - Make array_rand() more efficient

There are still a couple of tweaks to the implementation to be done before
merging:

* Make ranged output the same on 32 and 64 bit platforms where max-min is
less than 32 bits
* In compatibility mode use the old RAND_RANGE for mt_rand()

I intend to make time for these fixes tomorrow.

--001a113fc21a10ad320537b5a9cb--