Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:94475
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.223.177 as permitted sender)
MIME-Version: 1.0
Sender: jesseschalken@gmail.com
In-Reply-To: <CADyq6sJE-tzXTORYO1RkRHSOaZ6p+A-qOu_Rzn44Nq2CiLc_Ug@mail.gmail.com>
References: <CADBV+ZBOTQvSDVvYh6if-wjTGE=pZ9878vvZrD9CoJHuqJwoow@mail.gmail.com>
 <CADqTB_gOvO10uEr1-uMuHChcRpHmSip1jzE5WN6uReB8yM+VuQ@mail.gmail.com>
 <CAF1yvARMbCCYuZ77yUMy6xR+LT2Lv4ZmjdwVFT2dwtn3vZT2qw@mail.gmail.com> <CADyq6sJE-tzXTORYO1RkRHSOaZ6p+A-qOu_Rzn44Nq2CiLc_Ug@mail.gmail.com>
Date: Tue, 12 Jul 2016 05:51:15 +1000
Message-ID: <CAF1yvARLGi=+D9QjJ+7CKOH-pk_hisLd=+MaTKftW6ZLPn5ZmA@mail.gmail.com>
To: Marco Pivetta <ocramius@gmail.com>
Cc: Rasmus Schultz <rasmus@mindplay.dk>, Daniel Ciochiu <daniel@ciochiu.ro>, 
	PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a113fde08a22c2c0537617928
Subject: Re: [PHP-DEV] Proposal for php7 class method return
From: me@jesseschalken.com (Jesse Schalken)

--001a113fde08a22c2c0537617928
Content-Type: text/plain; charset=UTF-8

On Mon, Jul 11, 2016 at 10:18 PM, Marco Pivetta <ocramius@gmail.com> wrote:

> Hi Jesse,
>
> `return $this;` is a fairly common anti-pattern. It can be useful in few
> edge-cases, like immutable APIs (CoW) and DSL builders, but it's usually a
> bad idea. I ranted extensively about this at
> https://ocramius.github.io/blog/fluent-interfaces-are-evil/
>

I agree, but nonetheless at the cost of the problems both you (in your blog
post) and I have mentioned, "return $this;" does save the verbosity of
repeating a variable name, and often saves a variable altogether:

$blah = new Blah();
$blah->setFoo(1);
$blah->setBaz(2);
$this->setBlah($blah);


becomes

$this->setBlah((new Blah())
    ->setFoo(1)
    ->setBaz(2)
);


Some cascade operator or inline group method call/property set achieves the
same thing, but without all the problems of "return $this;":

$this->setBlah((new Blah())
    ->>setFoo(1)
    ->>setBaz(2)
);


$this->setBlah(new Blah() {
    setFoo(1),
    setBaz(2),
});


$this->setBlah(new Blah() {
    foo = 1,
    baz = 2,
});

--001a113fde08a22c2c0537617928--