Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:94437
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.161.175 as permitted sender)
To: Nikita Popov <nikita.ppv@gmail.com>,
 PHP internals <internals@lists.php.net>
References: <7716d180-2365-efc9-e9b3-9fe0998e273b@fleshgrinder.com>
 <CAF+90c_F_YgpsCkfAqZdj2VzeiUGRqUmmguGhHkf-9Tdrvt5Sg@mail.gmail.com>
Message-ID: <c8fa44b6-c7e9-c4ae-ce03-474c96ead2f6@gmail.com>
Date: Fri, 8 Jul 2016 15:19:58 -0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:45.0)
 Gecko/20100101 Thunderbird/45.1.1
MIME-Version: 1.0
In-Reply-To: <CAF+90c_F_YgpsCkfAqZdj2VzeiUGRqUmmguGhHkf-9Tdrvt5Sg@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] [RFC] [Vote] var_info
From: smalyshev@gmail.com (Stanislav Malyshev)

Hi!

> Lastly, I'll just leave this list of type-related improvements I'd actually
> like to see:
>  * Make is_object() return true for IncompleteClass. This is just
> ridiculous. I care zero about the theoretical BC impact.

I have no idea why it doesn't do so. I'll try to dig up when it was made
so and see if there's some explanation.

>  * Make gettype() return 'resource (unknown type)'  instead of just
> 'unknown type' for closed resources. This makes the output clear while
> still leaving the closed resource distinction.

That makes total sense. And BC impact is rather minimal given that
closed resources are useless.

>  * Normalize error message. IIRC currently our type error messages are
> really weird, in that they use terms like "integer" which are not actually
> valid type hints (or have different meaning). Fixing this doesn't even need
> a proposal, just a PR.

Right. But ensure tests are fixed, that's probably where one has to
spend some time on cleaning it up.

-- 
Stas Malyshev
smalyshev@gmail.com