Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:94427 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 13941 invoked from network); 8 Jul 2016 01:43:56 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 8 Jul 2016 01:43:56 -0000 Authentication-Results: pb1.pair.com smtp.mail=yohgaki@ohgaki.net; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=yohgaki@ohgaki.net; sender-id=pass Received-SPF: pass (pb1.pair.com: domain ohgaki.net designates 180.42.98.130 as permitted sender) X-PHP-List-Original-Sender: yohgaki@ohgaki.net X-Host-Fingerprint: 180.42.98.130 ns1.es-i.jp Received: from [180.42.98.130] ([180.42.98.130:33287] helo=es-i.jp) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 8C/DF-18622-B550F775 for ; Thu, 07 Jul 2016 21:43:55 -0400 Received: (qmail 122868 invoked by uid 89); 8 Jul 2016 01:43:52 -0000 Received: from unknown (HELO mail-qt0-f180.google.com) (yohgaki@ohgaki.net@209.85.216.180) by 0 with ESMTPA; 8 Jul 2016 01:43:52 -0000 Received: by mail-qt0-f180.google.com with SMTP id m2so17672510qtd.1 for ; Thu, 07 Jul 2016 18:43:51 -0700 (PDT) X-Gm-Message-State: ALyK8tIzChhV3JeoNwB5RT7miGqy0UNu4Qck/4g5u1EmRpMpm81Ou37R7owDvPyhVgwb2zDbnAzGnnELgSJXcg== X-Received: by 10.237.39.167 with SMTP id a36mr5035543qtd.103.1467942226398; Thu, 07 Jul 2016 18:43:46 -0700 (PDT) MIME-Version: 1.0 Received: by 10.140.17.33 with HTTP; Thu, 7 Jul 2016 18:43:06 -0700 (PDT) In-Reply-To: References: Date: Fri, 8 Jul 2016 10:43:06 +0900 X-Gmail-Original-Message-ID: Message-ID: To: Derick Rethans Cc: "internals@lists.php.net" Content-Type: text/plain; charset=UTF-8 Subject: Re: [PHP-DEV] [RFC][VOTE] Session ID without hashing From: yohgaki@ohgaki.net (Yasuo Ohgaki) Hi Derick, On Thu, Jul 7, 2016 at 9:29 PM, Derick Rethans wrote: >> Hi all, >> >> Currently session module uses obsolete MD5 for session ID. With >> CSPRNG, hashing is redundant and needless. It adds hash module >> dependency and inefficient (There is no reason to use hash for CSPRNG >> generated bytes). >> >> This proposal cleans up session code by removing hash. >> >> https://wiki.php.net/rfc/session-id-without-hashing >> >> I set vote requires 2/3 support. >> Please describe the reason why when you against this RFC. Reasons are >> important for improvements! > > I'm voting "no" bceause of > > session.use_strict_mode (0 to 1) - Changed as insurance of broken PRNG implementation. > > And it not being mentioned in BC breaking changes. It changes behaviour > of session IDs, as it shown in the manual: > > session.use_strict_mode boolean > > session.use_strict_mode specifies whether the module will use strict > session id mode. If this mode is enabled, the module does not accept > uninitialized session ID. If uninitialized session ID is sent from > browser, new session ID is sent to browser. Applications are > protected from session fixation via session adoption with strict > mode. Defaults to 0 (disabled). It was moved to other RFC. https://wiki.php.net/rfc/session-use-strict-mode Regards, -- Yasuo Ohgaki yohgaki@ohgaki.net