Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:94405 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 37391 invoked from network); 7 Jul 2016 08:25:09 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 7 Jul 2016 08:25:09 -0000 Authentication-Results: pb1.pair.com smtp.mail=leight@gmail.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=leight@gmail.com; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.215.52 as permitted sender) X-PHP-List-Original-Sender: leight@gmail.com X-Host-Fingerprint: 209.85.215.52 mail-lf0-f52.google.com Received: from [209.85.215.52] ([209.85.215.52:34157] helo=mail-lf0-f52.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 18/C4-18622-3E11E775 for ; Thu, 07 Jul 2016 04:25:08 -0400 Received: by mail-lf0-f52.google.com with SMTP id h129so6506637lfh.1 for ; Thu, 07 Jul 2016 01:25:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=g4bQOdZngnRNFUd6zAN8JFT9pKAUex4vDPW3gwYJY94=; b=GU2dZHTv2zPkbaJp6SOyu37vgBLBCykf6bIhOg3HMauXqc18A8Fhwa8jvbhphKRyfU ljbgSkAYwqgrpMMXmo6vjf4DtyvzHHERIrGXpJlhLQbMdrILHOgl1h7AA/Pb61KtWjbw oVGkMoJNu5tZ0aKNgHGyreNL/dtI7i3brJ6DCD+qH2h3zDIncNiJhRIrMUtNOgSpo+j9 c4IXGLM9dyqvpTagqSd6aTinIXbxZ6ZHPs7oCan8aaGn7BJxT7zwisOckbwu6mupg9jZ PmLGSUkOAaQNDPqC4V6ydnNLQrfLJLlvWpa+Jl+Q/cQ+GEW43eMzmXyUxPXbnWCw2oGi 8UBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=g4bQOdZngnRNFUd6zAN8JFT9pKAUex4vDPW3gwYJY94=; b=U4swS+XHshXlj2rbDLXmhlq1+nxwau6NBg4FYqfL4YLu+7S037l7XhYF8fCR2MJqE3 jgrRddON5Z5LORjWIM1/+pk4CSzIa+Fww0XWL9DmkfzWkfoFsCt6emo1h4LKiF2DfZ03 dEzur3jB1s21yPd+QaTeokT/XQs15N1yMZLiZBUi2tqmg+3GT/4ZkrTy1eSdqBvjRQNb MDzLrCq+WQl5h6/EALN2xZcdq69IMzKhc4o2KNguTj6UNR2KxENGXMv82FvW6rzp0Uny pXuF4ffGR24LBRiuuQ81BTJJqxfhkW8TVmeTJ8HTKw6MEVnbg8MN/MIXrmNHIjJfWMYD z3Pw== X-Gm-Message-State: ALyK8tJ2aIk5CP2c9BxZK2EH6Akw6jmnjC0uZyowTvQamZVCBYDwgSvmJdNmZxHxd7ME+iIaFCrUxA1JEjt9pQ== X-Received: by 10.25.136.11 with SMTP id k11mr5917767lfd.134.1467879904079; Thu, 07 Jul 2016 01:25:04 -0700 (PDT) MIME-Version: 1.0 Received: by 10.25.27.77 with HTTP; Thu, 7 Jul 2016 01:25:03 -0700 (PDT) In-Reply-To: References: <9e874892-d682-1c0d-77ad-21d5b44ce25b@gmx.de> Date: Thu, 7 Jul 2016 09:25:03 +0100 Message-ID: To: Yasuo Ohgaki Cc: Christoph Becker , Pierre Joye , Dan Ackroyd , PHP internals , Stanislav Malyshev Content-Type: text/plain; charset=UTF-8 Subject: Re: [PHP-DEV] Re: [RFC][VOTE] Session ID without hashing From: leight@gmail.com (Leigh) On 6 July 2016 at 22:30, Yasuo Ohgaki wrote: > php_session_create_id() may return NULL. It's an usual error. Session > module supports session ID creation save handler which may return > anything valid for the type. > > Session module tries to call php_session_create_id() several > places/times. If it could not get valid one, it raises > E_RECOVERABLE_ERROR or E_ERROR eventually. > > Although it's not enabled yet, PHP_FUNCTION(session_create_id) returns > FALSE it fails. If it fails due to a lack of random, it throws a fatal. Tested your PR and forced the fd of /dev/urandom to -1 in ext/standard/random.c $ sapi/cli/php -n -r 'session_start();' Next Exception: Cannot open source device in Command line code:1 Stack trace: #0 Command line code(1): session_start() #1 {main} thrown in Command line code on line 1 Fatal error: session_start(): Failed to create session ID: files (path: ) in Command line code on line 1