Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:94400
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 74.125.82.44 as permitted sender)
References: <CAFMT4Noe07E9--sasW-Fiw5B1hFFZbXDG2_wumkfZCbqM9wh7A@mail.gmail.com>
 <CAF+90c9RCfLdFGgLVXtc3iPy-LcPK3cfKqHNz-7Mm+QygER1Tg@mail.gmail.com>
 <1f39f97a-6aaf-8550-9f82-a7e80465f903@telia.com>
 <CAFMT4NrEPA31tL-vuyOHSO6=w+HjzGD6e-WUwyeROP2PKZ82Qw@mail.gmail.com>
 <be735c2f-ffa7-f430-3acf-09c5d13062fa@gmail.com>
 <CAFMT4Nq0JZ5=L9S-5SXknX-xLSeXLCqDp+D3J7R1_ecXzQ6rOA@mail.gmail.com>
To: internals <internals@lists.php.net>
Message-ID: <319e2640-4f81-7b13-5135-be406e35c814@gmail.com>
Date: Wed, 6 Jul 2016 10:23:11 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.1.1
MIME-Version: 1.0
In-Reply-To: <CAFMT4Nq0JZ5=L9S-5SXknX-xLSeXLCqDp+D3J7R1_ecXzQ6rOA@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] [RFC][Vote] ReflectionType Improvements
From: rowan.collins@gmail.com (Rowan Collins)

On 05/07/2016 22:06, Levi Morrison wrote:
> Compare that to using only if-else for control flow:
>
>     if ($type->isBuiltin()) {
>         handle_builtin();
>     } else if ($type instanceof ReflectionClassType) {
>         handle_class($type);
>     } else {
>         handle_undefined($type);
>     }
>
> I'd much prefer the latter.

Yeah, I agree the control flow looks more natural with an elseif there. 
But that fits fine with my other suggestion:

     if ($type->isBuiltin()) {
         handle_builtin();
     } else if ( object_type_exists($type->getName()) ) {
         handle_class($type);
     } else {
         handle_undefined($type);
     }


As I say, if you dislike the verbosity and future-proofing of 
"class_exists() || interface_exists()", then that's not uniqe to this 
situation, but a general lack in the language. Why add methods or whole 
types to this one area of reflection rather than providing a more basic 
building block?


> It would have been great if people actually contributed to the
> discussion before voting phase, but such is life.

Yes, for my part, I apologise that I didn't pay any attention to this 
RFC previously, and just happened upon this sub-thread. I can understand 
your frustration at this all coming so late.

Regards,
-- 
Rowan Collins
[IMSoP]