Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:94395
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.220.54 as permitted sender)
MIME-Version: 1.0
Sender: morrison.levi@gmail.com
In-Reply-To: <13e40d6f-c63c-6d0b-db09-7f5805ed018c@gmx.de>
References: <CAFMT4Noe07E9--sasW-Fiw5B1hFFZbXDG2_wumkfZCbqM9wh7A@mail.gmail.com>
 <CAF+90c9RCfLdFGgLVXtc3iPy-LcPK3cfKqHNz-7Mm+QygER1Tg@mail.gmail.com>
 <1f39f97a-6aaf-8550-9f82-a7e80465f903@telia.com> <CAFMT4NrEPA31tL-vuyOHSO6=w+HjzGD6e-WUwyeROP2PKZ82Qw@mail.gmail.com>
 <13e40d6f-c63c-6d0b-db09-7f5805ed018c@gmx.de>
Date: Tue, 5 Jul 2016 15:06:31 -0600
Message-ID: <CAFMT4NopPMaho0qScz0fBkpYe5MXqL+kFkrya4vQs9VR0-9Q9A@mail.gmail.com>
To: Christoph Becker <cmbecker69@gmx.de>
Cc: =?UTF-8?Q?Bj=C3=B6rn_Larsson?= <bjorn.x.larsson@telia.com>, 
	Nikita Popov <nikita.ppv@gmail.com>, PHP internals <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [PHP-DEV] [RFC][Vote] ReflectionType Improvements
From: levim@php.net (Levi Morrison)

> Another (minor) issue I have with the RFC is the introduction of
> ReflectionNamedType.  A simpler alternative appears to be to add the
> getName() method to ReflectionType; for unnamed types this could simply
> return (string) $reflectionType.  That might not be the most farsighted
> design decision, though.

The problem is that if something such as union types or intersection
types does pass those types are not named. While the current iteration
of union types failed it is possible a future RFC can pass (for the
record the vote was 11-18).

> To add to this, another issue we discussed OTR but didn't really come to a conclusion on, is the handling of self and parent type hints by ReflectionClassType.

The implementation I have will return ReflectionNamedType for self and
parent. There isn't any special casing for it. Rather since we forbid
defining types with these names they won't exist when the check
happens and it will fall back to ReflectionNamedType. As pointed out
these cannot always be resolved because of traits so this behavior
seems sensible. I think the RFC should be amended to specify this
behavior.