Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:94394
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.192.176 as permitted sender)
MIME-Version: 1.0
Sender: morrison.levi@gmail.com
In-Reply-To: <be735c2f-ffa7-f430-3acf-09c5d13062fa@gmail.com>
References: <CAFMT4Noe07E9--sasW-Fiw5B1hFFZbXDG2_wumkfZCbqM9wh7A@mail.gmail.com>
 <CAF+90c9RCfLdFGgLVXtc3iPy-LcPK3cfKqHNz-7Mm+QygER1Tg@mail.gmail.com>
 <1f39f97a-6aaf-8550-9f82-a7e80465f903@telia.com> <CAFMT4NrEPA31tL-vuyOHSO6=w+HjzGD6e-WUwyeROP2PKZ82Qw@mail.gmail.com>
 <be735c2f-ffa7-f430-3acf-09c5d13062fa@gmail.com>
Date: Tue, 5 Jul 2016 15:06:12 -0600
Message-ID: <CAFMT4Nq0JZ5=L9S-5SXknX-xLSeXLCqDp+D3J7R1_ecXzQ6rOA@mail.gmail.com>
To: Rowan Collins <rowan.collins@gmail.com>
Cc: internals <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [PHP-DEV] [RFC][Vote] ReflectionType Improvements
From: levim@php.net (Levi Morrison)

> Or if the aim is to simplify the reflection usage, why require the if
> statement at all:
>
> try {
>     $r = $type->getReflectionClass();
> } catch ( ReflectionException $e ) {
>     // type is builtin or refers to an undefined class
> }

I don't think this is actually simpler if you expand the comment to
handle both cases:

    try {
        $r = $type->getReflectionClass();
       handle_class($type);
    } catch (ReflectionException $e) {
        if ($type->isBuiltin()) {
            handle_builtin();
        } else {
            handle_undefined($type);
        }
    }

Compare that to using only if-else for control flow:

    if ($type->isBuiltin()) {
        handle_builtin();
    } else if ($type instanceof ReflectionClassType) {
        handle_class($type);
    } else {
        handle_undefined($type);
    }

I'd much prefer the latter.

Another option is adding a method `hasClass()` that would return
`true` if a `getClass()` call would be considered valid and `false`
otherwise. To me this doesn't seem as good as subtypes but consider it
better than forcing a caller to handle an exception in a situation
that I don't consider exceptional.

It would have been great if people actually contributed to the
discussion before voting phase, but such is life.