Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:94318
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain garfieldtech.com from 66.111.4.27 cause and error)
To: internals@lists.php.net
References: <CADqTB_i5WL+rzCuFHkRmXsPj16WDc4eWmpAoFmyeuYXvuOP_NQ@mail.gmail.com>
 <211db59e-9c22-6df4-1f72-66ebbc5095bd@fleshgrinder.com>
 <CADqTB_gyjkVZ50c1x=c4mUSs3q0UvzzZdcLm6iJZGD=E+2n1VA@mail.gmail.com>
 <CADyq6s+cNM0RMpvGF_0qmhU1Wpx=_zK6O3kKLxUr-Vu-7jJXNg@mail.gmail.com>
 <CAJGzsHojxcw-KBDw+c8RkF9c2qCRkfKkm-VXQCSa4PaRmmT5KA@mail.gmail.com>
 <CADqTB_gRbArM4A9MWTkO8_pGwn+9+toXWsFbD1avNL+STEwidA@mail.gmail.com>
 <CAJGzsHrdQkWNRdBcakh8X2qsJGqopojZWoD9i5BqjUP_DZ1H6Q@mail.gmail.com>
 <CADqTB_hmZz_JbUcQn7g0+5tzuhKonXBigJp9ArhEGsrzRbU=Tg@mail.gmail.com>
Message-ID: <57730DC8.5090607@garfieldtech.com>
Date: Tue, 28 Jun 2016 18:52:40 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.8.0
MIME-Version: 1.0
In-Reply-To: <CADqTB_hmZz_JbUcQn7g0+5tzuhKonXBigJp9ArhEGsrzRbU=Tg@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] [RFC] Simple Annotations
From: larry@garfieldtech.com (Larry Garfield)

On 06/28/2016 04:24 PM, Rasmus Schultz wrote:
> This was just an example of a value object - for example:
>
> class HttpMethod {
>      private $method;
>
>      protected function __construct($method) {
>          $this->method = $method;
>      }
>
>      public function getMethod() {
>          return $this->method;
>      }
>
>      public static function get() {
>          return new self("GET");
>      }
>
>      public static function post() {
>          return new self("POST");
>      }
>
>      // ...
> }
>
> You could picture using a flyweight constructor inside those factory
> methods maybe, and probably other patterns... I think there's plenty
> of cases for "named constructors", this is just the PHP variety of
> that. There are also cases (such as this one) where only certain
> constructions are permitted - allowing any string for HTTP method
> (e.g. wrong names, wrong case etc.) is prevented by protecting the
> constructor...

A possibly uglier but useful case would be where you have a large number 
of properties in an annotation and want to pass them in by name, but not 
using an anonymous array.  (See also, my earlier Drupal examples.)

To wit:

<<Node::definition()>>
class Node {

   public static function definition() {
     $def = new NodeDefinition();
     $def->name = "node";
     $def->label = "A Node";
     $def->addLink('foo', 'bar');
     // ...
     return $def;
   }

   // The rest of the node class here.
}

$annotations = $class_reflection->getAnnotations();

print get_class($annotations[0]); // prints "NodeDefinition".

Or would that fail because it's not returning a self instance, but of 
another class?

Rasmus, let me know when you have a proposal together and I'll try to 
dig up time to try rendering Drupal annotations in it again. :-)

--Larry Garfield