Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:94314 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 87408 invoked from network); 28 Jun 2016 18:11:06 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 28 Jun 2016 18:11:06 -0000 Authentication-Results: pb1.pair.com header.from=smalyshev@gmail.com; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=smalyshev@gmail.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.220.169 as permitted sender) X-PHP-List-Original-Sender: smalyshev@gmail.com X-Host-Fingerprint: 209.85.220.169 mail-qk0-f169.google.com Received: from [209.85.220.169] ([209.85.220.169:35632] helo=mail-qk0-f169.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id EC/D7-41838-8BDB2775 for ; Tue, 28 Jun 2016 14:11:04 -0400 Received: by mail-qk0-f169.google.com with SMTP id a125so44804979qkc.2 for ; Tue, 28 Jun 2016 11:11:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=subject:references:from:to:message-id:date:user-agent:mime-version :in-reply-to:content-transfer-encoding; bh=XHSCkSL3qlorC4dRe8h1sqCMsJJhK77ydG9FUhLCLWA=; b=oqAg4xK5DNAsRApWQryIf+0Xt47i28J9sV7A0eAnDBNXW4HRvS6vhM1fV//72o2pL7 hr3ZYS8vH8mvmNgokCZEQbHd4rPZL/yVF6WTTcypTXgOJstmyDmIEIlM8fJrnV689wwa 9FTPgLClDgpS70CXPqudukIaq6bwUtoRBCTdiaxCwVlv+SxBTfbJaYu0ej7KMAvDj3h7 vXw55rP/Q6p0p4Wre1Jantoo43ABWGH9vPnxQ7lEipt2iNw9TaBzoPYR4X0c9iXAwbUp 3nAgGThhz7GoePs+yZklcE4YHFtq86zo3CJT9WVVAYr9NPNtdurOsCDxIPMhBVXkSskN UwBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:references:from:to:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=XHSCkSL3qlorC4dRe8h1sqCMsJJhK77ydG9FUhLCLWA=; b=fmRyNywoHH6g9S7p+HEjz+rwD8RFiTCPm3uJuWD+bYlEY1gbvOyZnuAtJcsj3M7AMR qmv4LZoDnGt7QisxaWIManHEA8gMoWW9XZO8R/zB0cwF9IyjafsFfbw2yW86bz2IkOyM s44knw0ZWWKMFX6G+i5B2F26weJ9/OPz8UJb6l0A0/1VB015j8uMw4alqT+SGWMBWAVn WgRrkDFQEZfUXHZAs7WcFyMkJ+rjTM7swGUSLGWylfwtxe6z2RvMzYrUELe7T7mCEjuX QpOzg+caH0ISjkithydkSthfdS3jYQL/QvO/cgECyxoOwm9LBAtq1YYrSZsQ5PyJ3YI2 NmDg== X-Gm-Message-State: ALyK8tJhqsrO3yK/HRnIfdCODnBdug4OU9CfMaT7mjK5UvcNJhWe50ngr0eibwyU+8POKA== X-Received: by 10.129.85.76 with SMTP id j73mr1578640ywb.233.1467137461932; Tue, 28 Jun 2016 11:11:01 -0700 (PDT) Received: from [192.168.1.65] (76-220-46-95.lightspeed.sntcca.sbcglobal.net. [76.220.46.95]) by smtp.gmail.com with ESMTPSA id q188sm585987ywh.35.2016.06.28.11.10.59 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 28 Jun 2016 11:11:00 -0700 (PDT) References: To: PHP internals Message-ID: Date: Tue, 28 Jun 2016 11:10:55 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] [RFC][Vote] Throw Error in Extensions From: smalyshev@gmail.com (Stanislav Malyshev) Hi! >> Voting has opened on the RFC to change most conditions in extensions that raise E_ERROR or E_RECOVERABLE_ERROR to throw an instance of Error instead. >> >> RFC: https://wiki.php.net/rfc/throw_error_in_extensions >> PR: https://github.com/php/php-src/pull/1942 Isn't there a case that php_error(E_ERROR) does not return? At least it was in 5.x, I'm not sure if that didn't change. If so, we need to be very careful here - some code may make assumptions about the things because of previous E_ERROR conditions, and if zend_throw_error returns where php_error didn't there might be subtle and dangerous bugs. -- Stas Malyshev smalyshev@gmail.com