Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:94310 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 80534 invoked from network); 28 Jun 2016 17:28:21 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 28 Jun 2016 17:28:21 -0000 Authentication-Results: pb1.pair.com smtp.mail=jakub.php@gmail.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=jakub.php@gmail.com; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.220.175 as permitted sender) X-PHP-List-Original-Sender: jakub.php@gmail.com X-Host-Fingerprint: 209.85.220.175 mail-qk0-f175.google.com Received: from [209.85.220.175] ([209.85.220.175:33897] helo=mail-qk0-f175.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id BD/66-41838-4B3B2775 for ; Tue, 28 Jun 2016 13:28:20 -0400 Received: by mail-qk0-f175.google.com with SMTP id t127so42448033qkf.1 for ; Tue, 28 Jun 2016 10:28:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=ThHEtRfuRBcQAaPC7mPBrSkGuh5YhNUl8r0huDbFN3k=; b=Z4PU+uRlMVHCF39zlg9EFCEBjKwhELBkQ95szkOjtvhEITJmJcfVKpvtyZ/qMUHQ6p mu4BTqkNEyoWsZXvTdVEYdAcvPimWpn8FoB3kPnLFmKSS1FNWDve4e6U7n5p3aiH3+ld Gax9OC6KZ2eKO1wIW0B1RhNZa+Su2BxEG51kbkjtlM4Y5GjSjlSCTVeToiS/OAiLq8OY rMUHVH+DU9jRA/zOw6DM5duJzShokCDYjJcpf4PrXPh7CMHJL8R2jJDiwQwGPPxnwI/I d9fuGo4sqTRBj+1p9YqWo+MZzAiWUENVDOtscik2fi1DxS/vf7C8e6D3UjaxXjRkRCXn s5mg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=ThHEtRfuRBcQAaPC7mPBrSkGuh5YhNUl8r0huDbFN3k=; b=FWnI8BsJn3a6OYTZFn/yopvg+zSpTJxVXPmLTuEVPU+JOTYBaT/PenSLjqfbYULLKa sjtiZC96A1BCdgo18c89WFHvVIdd6ovUgZwD+lBzjg29MZ1jkJDMcahEwVkwxvScwYt1 l/zgLiLy3GIhtpqQNwIu5hX/B4kInvIlVTKzaF8p65NiSIdV4UiNMwYJwxFf4hor9JFp 3DjvgVn7JQClsLs0vNRbnjjy6tCZhk2tgforp3OecPURKxt389WS7aS33djgmVoJTz9P gFanRI+J2F05WHxebf+vSjIKAxDjTMnqNmJy9O9OX7KfUtwuQswTds+cqT1r56ZUYdV2 dJeQ== X-Gm-Message-State: ALyK8tK6C1QaaKeNF6HVtratQFMWQNOHAKnMdv3z6EnWczkJ5wmHE1TkZ5tPKYuVlarycWKgYVL+boxju+vrag== X-Received: by 10.13.218.65 with SMTP id c62mr1526618ywe.36.1467134897822; Tue, 28 Jun 2016 10:28:17 -0700 (PDT) MIME-Version: 1.0 Sender: jakub.php@gmail.com Received: by 10.13.209.198 with HTTP; Tue, 28 Jun 2016 10:28:17 -0700 (PDT) In-Reply-To: References: Date: Tue, 28 Jun 2016 18:28:17 +0100 X-Google-Sender-Auth: 8TRM2RoJbvYU5LBSK11D77H2XYg Message-ID: To: Aaron Piotrowski Cc: PHP internals Content-Type: multipart/alternative; boundary=94eb2c0805086c2284053659f666 Subject: Re: [PHP-DEV] [RFC][Vote] Throw Error in Extensions From: bukka@php.net (Jakub Zelenka) --94eb2c0805086c2284053659f666 Content-Type: text/plain; charset=UTF-8 Hi, On Mon, Jun 27, 2016 at 4:17 PM, Aaron Piotrowski wrote: > Hello, > > Voting has opened on the RFC to change most conditions in extensions that > raise E_ERROR or E_RECOVERABLE_ERROR to throw an instance of Error instead. > > RFC: https://wiki.php.net/rfc/throw_error_in_extensions < > https://wiki.php.net/rfc/throw_error_in_extensions> > PR: https://github.com/php/php-src/pull/1942 < > https://github.com/php/php-src/pull/1942> > > Just noticed the openssl case in X509_digest and it's obviously oversight by whoever added that bit because it should be warning as it's for all other similar fails. I'm going to change it to warning to make it consistent. In general I agree with the idea but the patch should be a bit more sensible and considers consistency with other errors in the extension. It should be also reviewed by all active maintainers or regular contributors to the changed extensions before it gets merged so it might be a bit late for 7.1 Cheers Jakub --94eb2c0805086c2284053659f666--