Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:94274
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain pthreads.org from 209.85.213.45 cause and error)
MIME-Version: 1.0
In-Reply-To: <0902b9fe-01c4-a4c8-aa86-291c9be603cc@zend.com>
References: <BY2PR0201MB1784EB34012B17227BEEFB21BF2E0@BY2PR0201MB1784.namprd02.prod.outlook.com>
 <BLU436-SMTP211D522E570C6AFEBB87A56E2200@phx.gbl> <CAL=_i_n-Dn8mjYRszWNXo8G=Vk+vasL4+uzme4+wVVOkah6Q5w@mail.gmail.com>
 <CAEZPtU5LAoxRyKV=w6hhBct18VNtumBO2iRii-hgw9euAnt98A@mail.gmail.com>
 <CAL=_i_=U737Ag5D=SupPzeNhSMOpnhVpB08L24EVprPg1UrALQ@mail.gmail.com>
 <CAEZPtU6k+h8xvTLtKmPZKyzYxNNXL4=aD26KOryMJ2MfDOY6BA@mail.gmail.com> <0902b9fe-01c4-a4c8-aa86-291c9be603cc@zend.com>
Date: Mon, 27 Jun 2016 12:40:37 +0100
Message-ID: <CAL=_i_=Ua0O+opfsjxmFeZz7758kG8BmGoeSkxRA5Qwx_K2==w@mail.gmail.com>
To: Dmitry Stogov <dmitry@zend.com>
Cc: Pierre Joye <pierre.php@gmail.com>, Bob Weinand <bobwei9@hotmail.com>, 
	PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a11398fe638dc3b053640fda9
Subject: Re: [PHP-DEV] [RFC] Asynchronous Signal Handling (withiut TICKs and
 any additional overhead).
From: pthreads@pthreads.org (Joe Watkins)

--001a11398fe638dc3b053640fda9
Content-Type: text/plain; charset=UTF-8

Pierre,

    > It affects how signals are handled within the engine, obvioulsy.

    How signals are handled in the engine was already changed, the only
thing being proposed here is that ext/pcntl uses that new feature.

Cheers
Joe

On Mon, Jun 27, 2016 at 12:28 PM, Dmitry Stogov <dmitry@zend.com> wrote:

>
>
> On 06/27/2016 02:05 PM, Pierre Joye wrote:
>
>> On Mon, Jun 27, 2016 at 5:08 PM, Joe Watkins <pthreads@pthreads.org>
>> wrote:
>>
>>> Morning,
>>>
>>>      How is the impact wider than ext/pcntl ?
>>>
>> The implementation is only in pctnl. The feature is used indirectly by
>> the engine and makes it a core feature. Quote from the RFC:
>>
>> "Zend Engine in PHP 7.1 was extended with ability of safe time-out and
>> interrupt handling. Actually, PHP VM checks for EG(vm_interrupt) flag
>> on each loop iteration, user function entry or internal function exit,
>> and call callback function if necessary.
>>
>> I propose to use this ability to implement asynchronous signal
>> handling. Registered signal handlers are going to be called at some
>> points during user script execution without any overhead."
>>
>> and the test:
>>
>> <?php
>> ini_set("pcntl.async_signals", "1");
>> pcntl_signal(SIGTERM, function ($signo) { echo "Signal handler
>> called!\n"; });
>>
>> echo "Start!\n";
>> posix_kill(posix_getpid(), SIGTERM);
>> $i = 0; // dummy
>> echo "Done!\n";
>>
>> It affects how signals are handled within the engine, obvioulsy.
>>
>> I have no doubt that this RFC will be accepted, by large, so it is not
>> a big issue. However it does affect the engine so the 2/3 rule
>> applies.
>>
> We use 2/3 vote for "a feature affecting the language itself (new syntax
> for example)", not the engine internals.
>
> https://wiki.php.net/RFC/voting#voting
>
>

--001a11398fe638dc3b053640fda9--