Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:94260
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain basereality.com from 209.85.161.172 cause and error)
MIME-Version: 1.0
In-Reply-To: <151b8d23-39a8-376f-fefa-e48183826432@fleshgrinder.com>
References: <2c547cd2-408d-238b-2b5c-e6f7f24f0e7a@fleshgrinder.com> <151b8d23-39a8-376f-fefa-e48183826432@fleshgrinder.com>
Date: Sun, 26 Jun 2016 12:09:42 +0100
Message-ID: <CA+kxMuSNnoNo9bq931iFNaOC-aXqONg7sA=+074j-9=sxtwrAw@mail.gmail.com>
To: "internals@lists.php.net" <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [PHP-DEV] [RFC DISCUSSION] Error Storage Behavior
From: danack@basereality.com (Dan Ackroyd)

On 6/11/2016 5:48 PM, Fleshgrinder wrote:
> Currently error_get_last() always contains the last error that occurred,
> however, this is actually not desired if the last error was an exception
> that was caught.

Changing the behaviour of how errors are handled, to depend on what
happens after the error occurs, seems a really bad choice to me.

From https://bugs.php.net/bug.php?id=54043
> If you create a custom error handler which converts all PHP errors to exceptions,
> catching internal exceptions inline therefore throws another Exception in the custom error handler,

Can you provide a reproduce case for this? The code below has a custom
error handler; it is never called.

It's actually not that clear what problem you are trying to solve here.

> Should we treat it as a simple bug fix?

No, I don't think we can. First, wrong behaviour is a design flaw not
a bug, and second it's really not obvious that having weird complex
behaviour would be preferrable.

On 26 June 2016 at 08:08, Fleshgrinder <php@fleshgrinder.com> wrote:
> Any feedback here?

This month you've sent almost 4 emails a day to this list. That is an
incredibly high number for a list that is distributed to thousands of
people. This list would be much better served if there were fewer
emails, that contained more fully thought through proposals.

cheers
Dan





<?php


error_reporting(E_ALL);
set_error_handler('tierErrorHandler');
register_shutdown_function('shutdown');

$time = '9999-11-33'; // invalid
$timeZone = new DateTimeZone('UTC');

try {
$dateTime = new DateTime($time, $timeZone);
} catch (Exception $e) {
var_dump('Exception:', $e->getMessage());
}

echo 'END' . PHP_EOL;


function shutdown()
{
$error = error_get_last();
var_dump('Error ', @$error);
}

function tierErrorHandler($errorNumber, $errorMessage, $errorFile, $errorLine) {
    echo "Is this called?" . PHP_EOL;
    $message = "Error: [$errorNumber] $errorMessage in file $errorFile
on line $errorLine<br />\n";

    throw new \Exception($message);
}