Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:94236
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain zend.com designates 157.56.110.111 as permitted sender)
To: PHP internals <internals@lists.php.net>, "bishop@php.net"
	<bishop@php.net>, Joe Watkins <pthreads@pthreads.org>, "davey@php.net"
	<davey@php.net>
CC: David Walker <dave@mudsite.com>
Thread-Topic: [PHP-DEV] [RFC] Additional context in pcntl_signal handler (was
 Re: [PHP-DEV] pcntl_signal & sa_siginfo)
Thread-Index: AQHRzXOCZI4rWcggWEinsWOAulZeeJ/3VOijgAAJOWw=
Date: Thu, 23 Jun 2016 18:26:08 +0000
Message-ID: <BY2PR0201MB1784DDC492D3F62FDDC11AC0BF2D0@BY2PR0201MB1784.namprd02.prod.outlook.com>
References: <CAEYWF=7mEsM8wXXpM=d7vLnJRE9a_j7Jns=2P8zr4fOU1WS2eg@mail.gmail.com>,<BY2PR0201MB17843929BA08BE0DE6E0AF88BF2D0@BY2PR0201MB1784.namprd02.prod.outlook.com>
In-Reply-To: <BY2PR0201MB17843929BA08BE0DE6E0AF88BF2D0@BY2PR0201MB1784.namprd02.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: zend.com does not designate
 permitted sender hosts)
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: multipart/alternative;
	boundary="_000_BY2PR0201MB1784DDC492D3F62FDDC11AC0BF2D0BY2PR0201MB1784_"
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Jun 2016 18:26:08.8486
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 32210298-c08b-4829-8097-6b12c025a892
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR0201MB1784
Subject: Re: [PHP-DEV] [RFC] Additional context in pcntl_signal handler (was
 Re: [PHP-DEV] pcntl_signal & sa_siginfo)
From: dmitry@zend.com (Dmitry Stogov)

--_000_BY2PR0201MB1784DDC492D3F62FDDC11AC0BF2D0BY2PR0201MB1784_
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

BTW: I'm not sure what pcntl_sigaction() could return as the "oldact" argum=
ent..., so may be the original proposal is good enough.

________________________________
From: Dmitry Stogov <dmitry@zend.com>
Sent: Thursday, June 23, 2016 9:02:55 PM
To: PHP internals; bishop@php.net; Joe Watkins; davey@php.net
Cc: David Walker
Subject: Re: [PHP-DEV] [RFC] Additional context in pcntl_signal handler (wa=
s Re: [PHP-DEV] pcntl_signal & sa_siginfo)

Hi,


To keep maximum compatibility and eliminate unnecessary additional overhead=
, I would keep pcntl_signal() unchanged, but add pcntl_sigaction() with the=
 ability to specify the need for the second argument (In the same way as PO=
SIX does).


Joe, Davey, when we stop targeting new RFCs for 7.1?


Thanks. Dmitry.

________________________________
From: bishop.bettini@gmail.com <bishop.bettini@gmail.com> on behalf of Bish=
op Bettini <bishop@php.net>
Sent: Thursday, June 23, 2016 8:18:58 PM
To: PHP internals
Cc: David Walker
Subject: [PHP-DEV] [RFC] Additional context in pcntl_signal handler (was Re=
: [PHP-DEV] pcntl_signal & sa_siginfo)

Hi All,

David and I would like to propose a second array argument be added to
signal handlers registered with pcntl_signal
<http://php.net/manual/en/function.pcntl-signal.php>. The array passes
through kernel-provided signal context like the process ID sending the
signal.

https://wiki.php.net/rfc/additional-context-in-pcntl-signal-handler

RFC links to an implementation. Please try it out and let us know your
thoughts. This only adds an argument, so no BC break. Maybe too late, but
it'd be great to get this in 7.1.

Thanks!
bishop


On Mon, Jun 13, 2016 at 2:18 PM, David Walker <dave@mudsite.com> wrote:

> Hi All,
>
> Long-time lurker, first time questioner here.  I'm currently working on a
> project wherein I end up forking off many subprocesses, but am trying to
> keep tabs on the progress of individual forks by having the children send=
 a
> signal back up to their parent every so often.
>
> pcntl_socket, allows me to listen for expected user signals from processe=
s,
> however, the handler only allows a single argument the signalnumber.  I
> would like to extend the handler to accept a possible second argument.  I=
f
> compiled on a system with __siginfo_t it would use SA_SIGINFO when settin=
g
> up the signal listener, and populate a second argument to the user-callba=
ck
> which could be an array with at leas sa_pid and sa_uid (contents of _kill=
).
>
> So I'd like to source the list to see if this would be something that wou=
ld
> be welcomed, or if there would be other ideas on how to get some more inf=
o
> of the signal back to the PHP-side of the pcntl_signal.
>
> --
> Dave
>

--_000_BY2PR0201MB1784DDC492D3F62FDDC11AC0BF2D0BY2PR0201MB1784_--