Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:94197
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain zend.com designates 207.46.100.110 as permitted sender)
To: Nikita Popov <nikic@php.net>
CC: Oz Gilat <oz@zend.com>, PHP internals <internals@lists.php.net>
Thread-Topic: Fixing backtraces with custom get_class_name() handler
Thread-Index: AQHRzIem25poCEpqDkO/QDc2QA0eZA==
Date: Wed, 22 Jun 2016 13:14:58 +0000
Message-ID: <BY2PR0201MB17842502187CCC1A7AFE7090BF2C0@BY2PR0201MB1784.namprd02.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: zend.com does not designate
 permitted sender hosts)
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: multipart/alternative;
	boundary="_000_BY2PR0201MB17842502187CCC1A7AFE7090BF2C0BY2PR0201MB1784_"
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Jun 2016 13:14:58.2846
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 32210298-c08b-4829-8097-6b12c025a892
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR0201MB1781
Subject: Fixing backtraces with custom get_class_name() handler
From: dmitry@zend.com (Dmitry Stogov)

--_000_BY2PR0201MB17842502187CCC1A7AFE7090BF2C0BY2PR0201MB1784_
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable

Hi Nikita,


When we developed php 7.0, we replaced most calls to get_class_name() by si=
mple obj->ce->name reading.

However, this functionality was used by some 3-rd part extensions (e.g. Zen=
d JavaBridge and may be pecl/perl).

These extensions create proxy classes and control remote objects through RP=
C.

Actually, we broke the previous behavior of backtrace* and get_class()/get_=
parent_class() functions.


Backtrace may be fixed even in 7.0 with the following patch:


https://gist.github.com/dstogov/d84183da9b0d958dfe5cb8d711c8d677


However, we can't fix get_parent_class(), because we changed get_class_name=
() handler prototype (removed "parent" argument).

get_class() may be fixed but I don't like to do this without get_parent_cla=
ss(), because they are going to be inconsistent.


What do you think about fixing backtrace in 7.0?

In my opinion, it looks consistent with other "debug" functions, e.g. var_d=
ump() etc


Oz, as I understood, you already found a workaround for get_class/get_paren=
t_class introducing get_java_class(). right?

so, do you think it worth to fix get_class/get_parent_class in 7.1? (I thin=
k no)


Thanks. Dmitry.

--_000_BY2PR0201MB17842502187CCC1A7AFE7090BF2C0BY2PR0201MB1784_--