Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:94162
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain zend.com designates 65.55.169.132 as permitted sender)
To: Pierre Joye <pierre.php@gmail.com>
CC: PHP internals <internals@lists.php.net>, Stas Malyshev
	<smalyshev@gmail.com>
Thread-Topic: [PHP-DEV] [RFC] Throw Exception on Attempt of Constant
 Redefinition
Thread-Index: AQHRw1M9yKVP3Kv5KUGQ4D8qa0qTMJ/sXluAgADY8EGAAAXWgIAFos67
Date: Mon, 20 Jun 2016 20:42:43 +0000
Message-ID: <BY2PR0201MB1784185BC605C5DBA24F2E28BF2A0@BY2PR0201MB1784.namprd02.prod.outlook.com>
References: <BY2PR0201MB1784853FB024646DE2CE2E84BF500@BY2PR0201MB1784.namprd02.prod.outlook.com>
	<2765db1c-4fc4-acf5-eccc-156a266b0750@gmail.com>
	<B22E7C4633F9775C.bf55295a-c9a2-4daf-b8c8-e8aae8493fe3@mail.outlook.com>,<CAEZPtU6v+SxTcYnCYyH7MyQELm9e7tfbfgJgfQApZuu=vvmdZA@mail.gmail.com>
In-Reply-To: <CAEZPtU6v+SxTcYnCYyH7MyQELm9e7tfbfgJgfQApZuu=vvmdZA@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: zend.com does not designate
 permitted sender hosts)
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: multipart/alternative;
	boundary="_000_BY2PR0201MB1784185BC605C5DBA24F2E28BF2A0BY2PR0201MB1784_"
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Jun 2016 20:42:43.5270
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 32210298-c08b-4829-8097-6b12c025a892
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR0201MB1784
Subject: Re: [PHP-DEV] [RFC] Throw Exception on Attempt of Constant
 Redefinition
From: dmitry@zend.com (Dmitry Stogov)

--_000_BY2PR0201MB1784185BC605C5DBA24F2E28BF2A0BY2PR0201MB1784_
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

The RFC was updated to propose this change only for PHP 8.0, and thereby, v=
ote is delayed for uncertain time.

I think, changing "Notice: Constant %s already defined" into "Deprecated: .=
.." in 7.1 doesn't make a lot of sense.


Thanks. Dmitry.

________________________________
From: Pierre Joye <pierre.php@gmail.com>
Sent: Friday, June 17, 2016 9:31:33 AM
To: Dmitry Stogov
Cc: PHP internals; Stas Malyshev
Subject: Re: [PHP-DEV] [RFC] Throw Exception on Attempt of Constant Redefin=
ition


On Jun 17, 2016 1:10 PM, "Dmitry Stogov" <dmitry@zend.com<mailto:dmitry@zen=
d.com>> wrote:
>
> Got it :(
> Then this may be a serious BC break, and it's better to depricate it in 7=
.1 and throw exception only in 8.

Fully agree. Thanks :)

> Thanks. Dmitry.
>
>
>
> On Thu, Jun 16, 2016 at 8:14 PM +0300, "Stanislav Malyshev" <smalyshev@gm=
ail.com<mailto:smalyshev@gmail.com><mailto:smalyshev@gmail.com<mailto:smaly=
shev@gmail.com>>> wrote:
>
> Hi!
>
> > Please review: https://wiki.php.net/rfc/constant_redefinition
>
> I would propose to not throw an error if constant is redefined to
> exactly the same value. Some of the code might be doing this
> unknowingly, e.g. by writing include instead of include_once, and
> there's no real reason to break it.
>
> --
> Stas Malyshev
> smalyshev@gmail.com<mailto:smalyshev@gmail.com>

--_000_BY2PR0201MB1784185BC605C5DBA24F2E28BF2A0BY2PR0201MB1784_--