Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:94085
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain kelunik.com from 81.169.146.221 cause and error)
MIME-Version: 1.0
In-Reply-To: <98f97016-066e-b5a4-8d1d-4bca179315fa@gmx.de>
References: <CAEbg-4Y=DaJogK+EO8dH2x59Ak_vugwXxm4M4hPw4sgtSNqmug@mail.gmail.com>
 <2635b3b6-b971-9fb7-5def-26b86eafb54d@fleshgrinder.com> <CANUQDCiYhbyUBX-NTYTJ67er2h6VoqT88zUvhePNY8Q9bSxJJw@mail.gmail.com>
 <b87d8499-7575-435d-5ab6-fc0bd629e3ae@fleshgrinder.com> <CANUQDCgQBmvDJJnA6qMMi83TXzSi97eFUJY+2vSDOkJKXuc-ew@mail.gmail.com>
 <CAEbg-4aOf1opjUHJkMPERahcG2+8yYLNDzr4NO9siY7jxtcOUw@mail.gmail.com>
 <CAEbg-4YDOfUbR=skupt1LV3+07X-ocjtHxMqpKpaqbLtku6dJg@mail.gmail.com> <98f97016-066e-b5a4-8d1d-4bca179315fa@gmx.de>
Date: Fri, 17 Jun 2016 17:44:22 +0200
Message-ID: <CANUQDCjz1RwNddF0rB_pgudKuNiZNn2R1JtDAJkG8=x1iC6BGw@mail.gmail.com>
To: Christoph Becker <cmbecker69@gmx.de>
Cc: Alexander Lisachenko <lisachenko.it@gmail.com>, PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a114687ea92a7bf05357b3a6b
Subject: Re: [PHP-DEV] Throwing an Error for require expressions in PHP7.x
From: me@kelunik.com (Niklas Keller)

--001a114687ea92a7bf05357b3a6b
Content-Type: text/plain; charset=UTF-8

2016-06-17 11:46 GMT+02:00 Christoph Becker <cmbecker69@gmx.de>:

> On 17.06.2016 at 10:29, Alexander Lisachenko wrote:
>
> > Nikita, Dmitry, ping. What do you think, shouldn't we replace all
> possible
> > places with Fatal Errors with correct throwing of Error exceptions?  In
> > this concrete case it's for "require" operator.
> >
> > From what I can see Error will give us more control over the file loading
> > process and make it more atomic, because additional checks
> > if(file_exists($file) && is_readable($file)) generate extra stat
> commands,
> > they are slow and not reliable, because for highload projects, we can be
> in
> > the situation where "if" succeeded, but the "require" will fail because
> our
> > file was deleted immediately after check.
> >
> > Code like this:
> > try {
> >     require $fileName;
> > } catch (Error $e) {
> >     echo "Oops, maybe deleted? " . $e;
> > }
> >
> > is much more reliable than following, by using "include" instead of
> > "require". This was suggested in https://bugs.php.net/bug.php?id=72089:
>
> I have re-opened this ticket.
>
> > if (file_exists($fileName) && is_readable($fileName)) {
> >     @include $fileName; // Silencing errors for the case of
> race-condition,
> > etc
> > }
>
> I'm not generally against throwing exceptions from include (or several
> other filesystem functions, for that matter), but the BC break has to be
> considered.  I am, however, still opposed to offer the ability to catch
> a failing *require*.


Why?

--001a114687ea92a7bf05357b3a6b--