Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:94073 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 34242 invoked from network); 17 Jun 2016 09:57:14 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 17 Jun 2016 09:57:14 -0000 Authentication-Results: pb1.pair.com smtp.mail=php@beccati.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=php@beccati.com; sender-id=pass Received-SPF: pass (pb1.pair.com: domain beccati.com designates 176.9.114.167 as permitted sender) X-PHP-List-Original-Sender: php@beccati.com X-Host-Fingerprint: 176.9.114.167 spritz.beccati.com Received: from [176.9.114.167] ([176.9.114.167:45009] helo=mail.beccati.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 34/72-18862-879C3675 for ; Fri, 17 Jun 2016 05:57:13 -0400 Received: (qmail 20608 invoked from network); 17 Jun 2016 09:57:08 -0000 Received: from home.beccati.com (HELO ?192.168.1.202?) (88.149.176.119) by mail.beccati.com with SMTP; 17 Jun 2016 09:57:08 -0000 To: Pierre Joye , Dmitry Stogov References: Cc: Joe Watkins , PHP internals Message-ID: Date: Fri, 17 Jun 2016 11:57:01 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] [RFC] [Accepted] Replace "Missing argument" warning with "Too few arguments" exception From: php@beccati.com (Matteo Beccati) On 16/06/2016 08:18, Pierre Joye wrote: > Hi Dmitry > > I am sorry but I have to ask to wait before merging it. > > It is definitely not clear that: > > . The rfc was valid to begin with due to the short discussion time > . This BC is acceptable for 7.x As Dmitry pointed out the change has been merged. I had voted yes, and I was prepared to make a few adjustments to the legacy app I work with. You can imagine I was extremely surprised to see that the test suite was green this morning. There might still be some fixing required for the code that isn't covered by tests, but to me this BC-break seems almost irrelevant compared to what we had in 7.0 (e.g. PHP4 constructors or method signatures). Of course I can't speak for the majority of the applications out there, but I think Revive Adserver is a fairly good sample of legacy code one could find. Cheers -- Matteo Beccati Development & Consulting - http://www.beccati.com/