Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:94066 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 17236 invoked from network); 17 Jun 2016 06:31:39 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 17 Jun 2016 06:31:39 -0000 Authentication-Results: pb1.pair.com smtp.mail=pierre.php@gmail.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=pierre.php@gmail.com; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.218.50 as permitted sender) X-PHP-List-Original-Sender: pierre.php@gmail.com X-Host-Fingerprint: 209.85.218.50 mail-oi0-f50.google.com Received: from [209.85.218.50] ([209.85.218.50:36680] helo=mail-oi0-f50.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 36/5C-25388-A4993675 for ; Fri, 17 Jun 2016 02:31:39 -0400 Received: by mail-oi0-f50.google.com with SMTP id p204so103874892oih.3 for ; Thu, 16 Jun 2016 23:31:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc; bh=x72YtHyzCxMrhiKa39Od88sIppE1kIoQkFf0kH5ocBU=; b=S4YC3WAi5MiBOLNeZH9zIMoujkRK0md8AZ0K1XWyLNFUTTrdP0c+9Gfll3nmGGoqUD 4s2n+hNj2V2y+QXZEux93VnBb5WL4faH1aBBYdDPP9Te6nguE9wSaW4ETAsclHfYRuV2 QGXZwtLOFjottFFj0DEV763+F+WcLQ7WspnIUeu+DiHcYge/vy07zNgdMIMKPO0crDkS RoO33t2GkpzKtPGyzhvsA+gEwVuF1YqMfLpYwjXYX9Ucd1I9HoiuO0hbUJsv4wvNuunV ZmV5i9vD+YbpUfTHlX6F/eg8zL4gLdwGnXU4UV57HZGDVMF+xAbLwVeiW5REjcuiSTpz uMxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc; bh=x72YtHyzCxMrhiKa39Od88sIppE1kIoQkFf0kH5ocBU=; b=AbnmqFB6N+YP8a8JiQ/62qWwEeR9hGS1sL8ktQUWHxtLHf7HSeilCvNPkyhnwlm/6G ENlQIFqb1d/BDBtWSsIjdVQToNhTqDWVOYdc3XrOen81NZEPGgZD954hYnUNr1fKanH6 gpW7EkyYGJSHYB2At86OUeZWU8dofb5dgh2cWtfQIu9Ds9cFSmgR1PKRlzKIntJdj1Kg LZT9qQkKiCU+oXcxFgChKKwKY/5STaec0SFNuhFxuza6V7EidS6nji6HhE/Kjr364eIj CfvOj+4Qpfpd7uIt//fAsVBFbUuUlmSND/rWpdOxXuwZOMFmu0jcX07sXLEB7u46QtVT D4Mw== X-Gm-Message-State: ALyK8tKVuLaga96xAOHBuIFO1/Tt67dEyAgltqYQVMdlHqDna90E/VZUMtthYd5sFtiUA22gCGH9EtD6+HJVew== MIME-Version: 1.0 X-Received: by 10.157.9.66 with SMTP id 60mr515068otp.23.1466145095556; Thu, 16 Jun 2016 23:31:35 -0700 (PDT) Received: by 10.202.108.197 with HTTP; Thu, 16 Jun 2016 23:31:33 -0700 (PDT) Received: by 10.202.108.197 with HTTP; Thu, 16 Jun 2016 23:31:33 -0700 (PDT) In-Reply-To: References: <2765db1c-4fc4-acf5-eccc-156a266b0750@gmail.com> Date: Fri, 17 Jun 2016 13:31:33 +0700 Message-ID: To: Dmitry Stogov Cc: PHP internals , Stas Malyshev Content-Type: multipart/alternative; boundary=94eb2c04f7189c26010535738156 Subject: Re: [PHP-DEV] [RFC] Throw Exception on Attempt of Constant Redefinition From: pierre.php@gmail.com (Pierre Joye) --94eb2c04f7189c26010535738156 Content-Type: text/plain; charset=UTF-8 On Jun 17, 2016 1:10 PM, "Dmitry Stogov" wrote: > > Got it :( > Then this may be a serious BC break, and it's better to depricate it in 7.1 and throw exception only in 8. Fully agree. Thanks :) > Thanks. Dmitry. > > > > On Thu, Jun 16, 2016 at 8:14 PM +0300, "Stanislav Malyshev" < smalyshev@gmail.com> wrote: > > Hi! > > > Please review: https://wiki.php.net/rfc/constant_redefinition > > I would propose to not throw an error if constant is redefined to > exactly the same value. Some of the code might be doing this > unknowingly, e.g. by writing include instead of include_once, and > there's no real reason to break it. > > -- > Stas Malyshev > smalyshev@gmail.com --94eb2c04f7189c26010535738156--