Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:94048 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 62457 invoked from network); 16 Jun 2016 17:14:19 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 16 Jun 2016 17:14:19 -0000 Authentication-Results: pb1.pair.com smtp.mail=smalyshev@gmail.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=smalyshev@gmail.com; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.192.175 as permitted sender) X-PHP-List-Original-Sender: smalyshev@gmail.com X-Host-Fingerprint: 209.85.192.175 mail-pf0-f175.google.com Received: from [209.85.192.175] ([209.85.192.175:33665] helo=mail-pf0-f175.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 4F/B4-25388-96ED2675 for ; Thu, 16 Jun 2016 13:14:18 -0400 Received: by mail-pf0-f175.google.com with SMTP id i123so18029069pfg.0 for ; Thu, 16 Jun 2016 10:14:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-transfer-encoding; bh=ENrfex1FfqGWsMHWwazoPGhxLqLrBlgozZJbJL5kI90=; b=HwDlccYneCCDjyD/c9NqVloSGP8cXQlNZJ70fVkiR+yOVveUg96586vD4BTQtnkS6M GeJdkohaecbX5FNPxcu92koe4SydW6+L83e9xom66gvPl0afq1PO006KZY14gV+mKay5 IR2rH5ElBM+g0JFl0zoTKnqi1DKG/qEzDg5veBFGyz3ewjpWq70KGID23iEbPAvi8TCB VDb2mk5gSbrqAVc+X93bk6xOiYSpfxK9ihyN6268w5uOZEe5Z6209IRzCSoJ7fbTCsgI WYYvUZQA7DXOqJ0RQ9Ce86iRy3TP9Qn+rSaKS91yX3yas14oMSDEdTY2/Azd9ge+huxq hv0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=ENrfex1FfqGWsMHWwazoPGhxLqLrBlgozZJbJL5kI90=; b=Q/M8MxV4MZ9QiamfdnFaLgr4Cg5XB5ZQrrEXR+yf5GDjmUYU6mu5l1UjcahXoHb2lR 0WUdG+CM+iEjbSl/Ws5JF0FmRVklhum26qBplnUREVuxS14YyO8N96/QSLfbf685OCt8 qCcx/C4BVviWT47aK2dRHreINGbo4/FbGgEAYJ0J87UZ+Y2zO1m7NM10Zov4HCvpIAhx 5sjl3QLpnyZsCBHCPosKLpLxFBsmrryXX3T+QxluYGPuhUM9e8y7VH6W8KsnvL3C/BMQ ABcs6Z0bIKuZDNl2h0WRgLwZpcQBEwxC/KUUP2/zYJqqsZGi5lBjCXkeWeexOdEzcEYs JBOg== X-Gm-Message-State: ALyK8tJqvdnKnsLB+KaaBFznGD/FrWN9xSSrLpyA3LpYY0INdK6J8Y3UciXAG3frIfDEBA== X-Received: by 10.98.27.141 with SMTP id b135mr6481574pfb.111.1466097255142; Thu, 16 Jun 2016 10:14:15 -0700 (PDT) Received: from stas-air.corp.wikimedia.org (tan1.corp.wikimedia.org. [198.73.209.1]) by smtp.gmail.com with ESMTPSA id w2sm62104687pfb.46.2016.06.16.10.14.14 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 16 Jun 2016 10:14:14 -0700 (PDT) To: Dmitry Stogov , PHP internals References: Message-ID: <2765db1c-4fc4-acf5-eccc-156a266b0750@gmail.com> Date: Thu, 16 Jun 2016 10:14:13 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] [RFC] Throw Exception on Attempt of Constant Redefinition From: smalyshev@gmail.com (Stanislav Malyshev) Hi! > Please review: https://wiki.php.net/rfc/constant_redefinition I would propose to not throw an error if constant is redefined to exactly the same value. Some of the code might be doing this unknowingly, e.g. by writing include instead of include_once, and there's no real reason to break it. -- Stas Malyshev smalyshev@gmail.com