Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:94020
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain kelunik.com from 81.169.146.216 cause and error)
MIME-Version: 1.0
In-Reply-To: <2635b3b6-b971-9fb7-5def-26b86eafb54d@fleshgrinder.com>
References: <CAEbg-4Y=DaJogK+EO8dH2x59Ak_vugwXxm4M4hPw4sgtSNqmug@mail.gmail.com>
 <2635b3b6-b971-9fb7-5def-26b86eafb54d@fleshgrinder.com>
Date: Wed, 15 Jun 2016 19:52:57 +0200
Message-ID: <CANUQDCiYhbyUBX-NTYTJ67er2h6VoqT88zUvhePNY8Q9bSxJJw@mail.gmail.com>
To: PHP Internals <internals@lists.php.net>
Cc: Alexander Lisachenko <lisachenko.it@gmail.com>
Content-Type: multipart/alternative; boundary=001a1145b52cd38b24053554caec
Subject: Re: [PHP-DEV] Throwing an Error for require expressions in PHP7.x
From: me@kelunik.com (Niklas Keller)

--001a1145b52cd38b24053554caec
Content-Type: text/plain; charset=UTF-8

2016-06-15 19:38 GMT+02:00 Fleshgrinder <php@fleshgrinder.com>:

> On 6/15/2016 12:27 PM, Alexander Lisachenko wrote:
> > For PHP7 we have pretty errors for almost everything, even eval can
> throw a
> > ParseError exception, but not for the require expression, because it's
> > still producing an uncatchable fatal errors:
> >
> > try {
> >     require('no.php');
> > } catch (Throwable $e) {
> >     echo 'Catch!';
> > } finally {
> >     echo 'Finally?';
> > }
> > // Warning: require(no.php): failed to open stream: No such file or
> > directory
> > // Fatal error: require(): Failed opening required 'no.php'
> >
>
> This is exactly how require is meant to work, just use include as
> Christoph said already. These are two distinct features for a reason.
>
> On 6/15/2016 12:27 PM, Alexander Lisachenko wrote:
> > Can we also add FileNotFoundException and use it for all file functions
> to
> > avoid silencing with "@" operator? Then require expression can throw an
> > Error with nested FileNotFoundException.
> >
>
> We definitely need this but it cannot go into PHP 7.0.


I think it can go into 7.1. It's not a BC break, as it will still produce a
fatal error if the error isn't caught.


>
> --
> Richard "Fleshgrinder" Fussenegger
>
>

--001a1145b52cd38b24053554caec--