Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:93911
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain mindplay.dk from 209.85.213.53 cause and error)
MIME-Version: 1.0
In-Reply-To: <CAGa2bXY+xKNRn+Z28QJOkLrdWunNR7QcNn8XXuHDp2ws4exXcQ@mail.gmail.com>
References: <CAL=_i_ndnBUEHUcNxPJxxkhZ70jM4xE-xkjuftWpHHNSKMchOA@mail.gmail.com>
 <BY2PR0201MB1784884D794E3FF56E08D124BF500@BY2PR0201MB1784.namprd02.prod.outlook.com>
 <CAGa2bXY+xKNRn+Z28QJOkLrdWunNR7QcNn8XXuHDp2ws4exXcQ@mail.gmail.com>
Date: Sun, 12 Jun 2016 15:03:57 +0200
Message-ID: <CADqTB_h_TRUJqezT-zan6WWXAcZvnD9DPwY1H=ZH+RjtYE8PSA@mail.gmail.com>
To: Yasuo Ohgaki <yohgaki@ohgaki.net>
Cc: Dmitry Stogov <dmitry@zend.com>, Joe Watkins <pthreads@pthreads.org>, 
	PHP internals <internals@lists.php.net>, Phil Sturgeon <pjsturgeon@gmail.com>
Content-Type: multipart/alternative; boundary=001a114dc4fead6967053514675a
Subject: Re: [PHP-DEV] [RFC][Vote] Typed Properties
From: rasmus@mindplay.dk (Rasmus Schultz)

--001a114dc4fead6967053514675a
Content-Type: text/plain; charset=UTF-8

Pretend I know (basically) nothing about how PHP was implemented, because I
don't ;-)

But I don't understand why regular property updates should be affected by
this at all?

If I had to implement type-checked properties in plain PHP, I would do
something like this...

/**
 * @property int $price
 */
class Product
{
    private $_price;

    public function __set($name, $value) {
        if ($name === "price") {
            if (!is_int($value)) {
                throw new UnexpectedValueException("...");
            }
            $this->_price = $price;
            return;
        }
        throw new RuntimeException("undefined property {$name}");
    }

    public function __get($name) {
        return $this->{"_{$name}"};
    }
}

I would have guessed an implementation of type-checked properties would
work in much the same way.

Of course, it wouldn't use "_" as a prefix for the underlying property, but
some other magic byte, much like how private properties are internally
prefixed with a magic byte, right?

This wouldn't affect the performance of untyped properties at all.

Of course typed property writes would be more expensive, but that's to be
expected.


On Sat, Jun 11, 2016 at 3:45 AM, Yasuo Ohgaki <yohgaki@ohgaki.net> wrote:

> Hi Dmitry,
>
> On Fri, Jun 10, 2016 at 9:37 PM, Dmitry Stogov <dmitry@zend.com> wrote:
> > I hardly worked on implementation of this patch for a week, but I still
> don't like it.
> >
> > It makes 15% slowdown on each property update in existing PHP code
> (without types), and I don't see a way to improve this.
> >
> > Update of typed properties is going to be even more expensive.
> >
> > Benchmark results are included into RFC (and not changed with the latest
> version of the patch).
> >
> >
> > -1.
>
> If we are concerned about performance, DbC would be the only solution
> for this kind of problem. i.e. Validate fully during development, do
> minimum validation on production. DbC helps type inference also. There
> may not be enough time for discussion, but do you think there is
> enough time for implementation? I suppose implementation is
> straightforward, so it might be OK to have RFC w/o implementation. We
> have 2 options anyway. It's waste of time for having 2
> implementations. Would you like to proceed the RFC for 7.1?
>
> Regards,
>
> --
> Yasuo Ohgaki
> yohgaki@ohgaki.net
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>
>

--001a114dc4fead6967053514675a--