Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:93895
Return-Path: <xinchen.h@zend.com>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 36819 invoked from network); 11 Jun 2016 07:49:05 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 11 Jun 2016 07:49:05 -0000
Authentication-Results: pb1.pair.com smtp.mail=xinchen.h@zend.com; spf=pass; sender-id=pass
Authentication-Results: pb1.pair.com header.from=laruence@php.net; sender-id=unknown
Received-SPF: pass (pb1.pair.com: domain zend.com designates 209.85.223.170 as permitted sender)
X-PHP-List-Original-Sender: xinchen.h@zend.com
X-Host-Fingerprint: 209.85.223.170 mail-io0-f170.google.com  
Received: from [209.85.223.170] ([209.85.223.170:33401] helo=mail-io0-f170.google.com)
	by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP
	id 00/43-04630-B62CB575 for <internals@lists.php.net>; Sat, 11 Jun 2016 03:49:00 -0400
Received: by mail-io0-f170.google.com with SMTP id m62so83707693iof.0
        for <internals@lists.php.net>; Sat, 11 Jun 2016 00:48:59 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20130820;
        h=x-gm-message-state:mime-version:in-reply-to:references:from:date
         :message-id:subject:to:cc;
        bh=T7GkCCpfBQ3zna2GtpVPyWTZDqG2p1NbCzKaZlBSflg=;
        b=BFBeJxClI+7HNzt7ZX6eLoCg49n71dcq4qb/EkOuXaV0pHFdshBlMpZVFQc2iQdQop
         vNSyhcJfmd/FQ2//nbuGkIkHSkMwv8sqB/LuYgpG+A0gLhqRG1wM60QuE/bJkPUGYdE+
         3R3Kw4WTOXeQimMU5KIc8geHmt8ut4P6huCP8GbDoiiZaDoCJfT//bOMSKw7JB2jPS5m
         /UvmNyv8Z6nd5gnsW1GliusC0klkYuwvefqQzOgb8+0Nkb/0LC1dfYAJ7eENdNqquO60
         o4N3VOdb/RsTiw/LfYIR1QH3aEi78bFTQ3zhsYxuy4JZEIHV2ruVbIelUg5VpkzmLjIi
         yYYw==
X-Gm-Message-State: ALyK8tKPWpQE6yfvAmlmHw/rLba2R1tqt28RQA2/rVpQm3FBUQAOzxTMAbB3vZiGAI8kT0UK
X-Received: by 10.107.154.130 with SMTP id c124mr10196956ioe.169.1465631337453;
        Sat, 11 Jun 2016 00:48:57 -0700 (PDT)
Received: from mail-io0-f181.google.com (mail-io0-f181.google.com. [209.85.223.181])
        by smtp.gmail.com with ESMTPSA id o5sm1418293ith.20.2016.06.11.00.48.56
        for <internals@lists.php.net>
        (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
        Sat, 11 Jun 2016 00:48:56 -0700 (PDT)
Received: by mail-io0-f181.google.com with SMTP id 5so83526033ioy.1
        for <internals@lists.php.net>; Sat, 11 Jun 2016 00:48:56 -0700 (PDT)
X-Received: by 10.107.41.202 with SMTP id p193mr10401335iop.106.1465631336000;
 Sat, 11 Jun 2016 00:48:56 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.79.67.198 with HTTP; Sat, 11 Jun 2016 00:48:36 -0700 (PDT)
In-Reply-To: <BY2PR0201MB1784853FB024646DE2CE2E84BF500@BY2PR0201MB1784.namprd02.prod.outlook.com>
References: <BY2PR0201MB1784853FB024646DE2CE2E84BF500@BY2PR0201MB1784.namprd02.prod.outlook.com>
Date: Sat, 11 Jun 2016 15:48:36 +0800
X-Gmail-Original-Message-ID: <CABBJUpdkZATU9HT_BMLh0GyN6436jzsv=dshyPP71FWiE0h=aw@mail.gmail.com>
Message-ID: <CABBJUpdkZATU9HT_BMLh0GyN6436jzsv=dshyPP71FWiE0h=aw@mail.gmail.com>
To: Dmitry Stogov <dmitry@zend.com>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a1141d8102777b20534fbe375
Subject: Re: [PHP-DEV] [RFC] Throw Exception on Attempt of Constant Redefinition
From: laruence@php.net (Xinchen Hui)

--001a1141d8102777b20534fbe375
Content-Type: text/plain; charset=UTF-8

Hey:

On Sat, Jun 11, 2016 at 4:06 AM, Dmitry Stogov <dmitry@zend.com> wrote:

> Hi internals,
>
>
> Please review: https://wiki.php.net/rfc/constant_redefinition


we could also change the

#define DEFAULT_OPTIMIZATION_LEVEL  "0x7FFFBFFF" (introduced in
https://github.com/php/php-src/commit/40702799b5f08b093477098881b6e0cfcb3ea411
)

to  -1

I think it's better also include this into the patch?

thanks

>
>
> Thanks. Dmitry.
>



-- 
Xinchen Hui
@Laruence
http://www.laruence.com/

--001a1141d8102777b20534fbe375--