Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:93890
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain zend.com designates 157.56.110.118 as permitted sender)
To: Levi Morrison <levim@php.net>
CC: PHP internals <internals@lists.php.net>
Thread-Topic: [PHP-DEV] [RFC] Throw Exception on Attempt of Constant
 Redefinition
Thread-Index: AQHRw1M9yKVP3Kv5KUGQ4D8qa0qTMJ/jLMcAgAAI16A=
Date: Fri, 10 Jun 2016 21:27:29 +0000
Message-ID: <BY2PR0201MB1784B29547CD35B1FE04B3ACBF500@BY2PR0201MB1784.namprd02.prod.outlook.com>
References: <BY2PR0201MB1784853FB024646DE2CE2E84BF500@BY2PR0201MB1784.namprd02.prod.outlook.com>,<CAFMT4NqzMgOq6-MWpwKZLGyEo=Sr7Swf7PviM_XgMgMkN3w46A@mail.gmail.com>
In-Reply-To: <CAFMT4NqzMgOq6-MWpwKZLGyEo=Sr7Swf7PviM_XgMgMkN3w46A@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: zend.com does not designate
 permitted sender hosts)
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: multipart/alternative;
	boundary="_000_BY2PR0201MB1784B29547CD35B1FE04B3ACBF500BY2PR0201MB1784_"
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Jun 2016 21:27:29.2507
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 32210298-c08b-4829-8097-6b12c025a892
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR0201MB1781
Subject: Re: [PHP-DEV] [RFC] Throw Exception on Attempt of Constant
 Redefinition
From: dmitry@zend.com (Dmitry Stogov)

--_000_BY2PR0201MB1784B29547CD35B1FE04B3ACBF500BY2PR0201MB1784_
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

In general, you are right, but this is possible only if application ignores=
 Error exceptions...


________________________________
From: morrison.levi@gmail.com <morrison.levi@gmail.com> on behalf of Levi M=
orrison <levim@php.net>
Sent: Friday, June 10, 2016 11:50:26 PM
To: Dmitry Stogov
Cc: PHP internals
Subject: Re: [PHP-DEV] [RFC] Throw Exception on Attempt of Constant Redefin=
ition

On Fri, Jun 10, 2016 at 2:06 PM, Dmitry Stogov <dmitry@zend.com> wrote:
> Hi internals,
>
>
> Please review: https://wiki.php.net/rfc/constant_redefinition
>
>
> Thanks. Dmitry.

Dmitry, I am not sure this change will actually allow constant
propagation either. Consider this code:

<?php
const Foo =3D 1;

class FooFactory {
  static function make() {
    return Foo;
  }
}
?>

In this series of events:

  - Foo is declared to be 0
  - This above file is now included inside a try-catch block that
catches the error
  - FooFactory::make() is now called

If Foo =3D 1 was propagated then FooFactory::make() will return 1 instead o=
f 0.

Am I missing something?

--_000_BY2PR0201MB1784B29547CD35B1FE04B3ACBF500BY2PR0201MB1784_--