Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:93887
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.192.180 as permitted sender)
MIME-Version: 1.0
Sender: morrison.levi@gmail.com
In-Reply-To: <BY2PR0201MB1784853FB024646DE2CE2E84BF500@BY2PR0201MB1784.namprd02.prod.outlook.com>
References: <BY2PR0201MB1784853FB024646DE2CE2E84BF500@BY2PR0201MB1784.namprd02.prod.outlook.com>
Date: Fri, 10 Jun 2016 14:50:26 -0600
Message-ID: <CAFMT4NqzMgOq6-MWpwKZLGyEo=Sr7Swf7PviM_XgMgMkN3w46A@mail.gmail.com>
To: Dmitry Stogov <dmitry@zend.com>
Cc: PHP internals <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [PHP-DEV] [RFC] Throw Exception on Attempt of Constant Redefinition
From: levim@php.net (Levi Morrison)

On Fri, Jun 10, 2016 at 2:06 PM, Dmitry Stogov <dmitry@zend.com> wrote:
> Hi internals,
>
>
> Please review: https://wiki.php.net/rfc/constant_redefinition
>
>
> Thanks. Dmitry.

Dmitry, I am not sure this change will actually allow constant
propagation either. Consider this code:

<?php
const Foo = 1;

class FooFactory {
  static function make() {
    return Foo;
  }
}
?>

In this series of events:

  - Foo is declared to be 0
  - This above file is now included inside a try-catch block that
catches the error
  - FooFactory::make() is now called

If Foo = 1 was propagated then FooFactory::make() will return 1 instead of 0.

Am I missing something?