Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:93870 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 64698 invoked from network); 10 Jun 2016 14:31:53 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 10 Jun 2016 14:31:53 -0000 Authentication-Results: pb1.pair.com header.from=bobwei9@hotmail.com; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=bobwei9@hotmail.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain hotmail.com designates 65.55.111.158 as permitted sender) X-PHP-List-Original-Sender: bobwei9@hotmail.com X-Host-Fingerprint: 65.55.111.158 blu004-omc4s19.hotmail.com Received: from [65.55.111.158] ([65.55.111.158:58537] helo=BLU004-OMC4S19.hotmail.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 16/E2-50092-75FCA575 for ; Fri, 10 Jun 2016 10:31:53 -0400 Received: from BLU436-SMTP87 ([65.55.111.137]) by BLU004-OMC4S19.hotmail.com over TLS secured channel with Microsoft SMTPSVC(7.5.7601.23008); Fri, 10 Jun 2016 07:31:48 -0700 X-TMN: [XEeSM3+Sq2k23OLJh0GNLWS6eHnbqhOT] X-Originating-Email: [bobwei9@hotmail.com] Message-ID: Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 (Mac OS X Mail 9.2 \(3112\)) In-Reply-To: Date: Fri, 10 Jun 2016 16:31:43 +0200 CC: Dmitry Stogov , Joe Watkins , PHP internals , Phil Sturgeon Content-Transfer-Encoding: quoted-printable References: To: Levi Morrison X-Mailer: Apple Mail (2.3112) X-OriginalArrivalTime: 10 Jun 2016 14:31:46.0450 (UTC) FILETIME=[D114DF20:01D1C324] Subject: Re: [PHP-DEV] [RFC][Vote] Typed Properties From: bobwei9@hotmail.com (Bob Weinand) > Am 10.06.2016 um 16:24 schrieb Levi Morrison : >=20 > On Fri, Jun 10, 2016 at 6:37 AM, Dmitry Stogov = wrote: >> Hi, >>=20 >>=20 >> I hardly worked on implementation of this patch for a week, but I = still don't like it. >>=20 >> It makes 15% slowdown on each property update in existing PHP code = (without types), and I don't see a way to improve this. >>=20 >> Update of typed properties is going to be even more expensive. >>=20 >> Benchmark results are included into RFC (and not changed with the = latest version of the patch). >>=20 >>=20 >> -1. >>=20 >>=20 >> Thanks. Dmitry. >>=20 >> ________________________________ >> From: Joe Watkins >> Sent: Friday, June 10, 2016 1:38:04 PM >> To: PHP internals; Phil Sturgeon >> Subject: [PHP-DEV] [RFC][Vote] Typed Properties >>=20 >> Afternoon internals, >>=20 >> The vote for typed properties has been restarted. >>=20 >> Please take part: https://wiki.php.net/rfc/typed-properties >>=20 >> Cheers >> Joe >=20 > To clarify though, didn't Wordpress and Mediawiki see only a 0.1% > slowdown? In my opinion that is definitely a tolerable performance hit > for such a feature. Right, the 15% are quite skewed =E2=80=A6 it's in a tight loop which = means ideal L1 cache utilization and the number of executed instructions = for a runtime-cached ASSIGN_OBJ is very small. Where even 4 additional = instructions make significant difference. The 0.1% slowdown of WP and MW are painting a much more realistic (aka = real-world) image. And as the RFC writes, "may be caused not by the = additional checks but by the worse CPU cache utilization, because the = size of PHP code was increased on 40KB".=20 These micro-benches are really insignificant, especially as it is = trivial (in tight loops) to work on a local CV and only assign it later = to the property. This IMO is really voting no for the wrong reasons... Bob=