Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:93860
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 74.125.82.42 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAL=_i_ndnBUEHUcNxPJxxkhZ70jM4xE-xkjuftWpHHNSKMchOA@mail.gmail.com>
References: <CAL=_i_ndnBUEHUcNxPJxxkhZ70jM4xE-xkjuftWpHHNSKMchOA@mail.gmail.com>
Date: Fri, 10 Jun 2016 14:39:16 +0200
Message-ID: <CADyq6sJ0LQuia0PfcXAPGRuZk=rd2V01+gT0Z=wr3B=b0Ei==A@mail.gmail.com>
To: Joe Watkins <pthreads@pthreads.org>
Cc: PHP internals <internals@lists.php.net>, Phil Sturgeon <pjsturgeon@gmail.com>
Content-Type: multipart/alternative; boundary=001a1148f25ccdfce50534ebd4b7
Subject: Re: [PHP-DEV] [RFC][Vote] Typed Properties
From: ocramius@gmail.com (Marco Pivetta)

--001a1148f25ccdfce50534ebd4b7
Content-Type: text/plain; charset=UTF-8

As already mentioned on twitter, I voted "no" on this RFC as it currently
stands. I might reconsider if following points are addressed:

 1. __get semantics are not changed: let __get behave like it usually does,
and let the user define a type hint on __get, should any be applicable.
Basically:

class Foo
{
    private int $bar = 123;
    public function __get($name) { return 'banana'; } // *ALWAYS* works -
why would I even want a type error here?
}

 * by-ref access should be enabled when the reference property has the same
declared type as the source one

class Foo
{
    public int $bar = 123;
}

class Bar
{
    public int $baz = 456;
    public string $taz = 'taz';
}

$foo = new Foo;
$bar = new Bar;

$bar->baz = & $foo->bar; // works
$bar->taz = & $foo->bar; // crashes

Cheers,


Marco Pivetta

http://twitter.com/Ocramius

http://ocramius.github.com/

On 10 June 2016 at 12:38, Joe Watkins <pthreads@pthreads.org> wrote:

> Afternoon internals,
>
>     The vote for typed properties has been restarted.
>
>     Please take part: https://wiki.php.net/rfc/typed-properties
>
> Cheers
> Joe
>

--001a1148f25ccdfce50534ebd4b7--