Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:93764
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain kelunik.com from 81.169.146.163 cause and error)
MIME-Version: 1.0
In-Reply-To: <BLU436-SMTP8648B1BCE09FBF02700F20E25A0@phx.gbl>
References: <BLU437-SMTP785CB095BE08FBC1CC2FAFE2580@phx.gbl>
 <0A.C5.62101.1C860575@pb1.pair.com> <a58caf44-dae1-c544-804f-089360243607@gmail.com>
 <BLU436-SMTP187447B1819635CD2E6962E2580@phx.gbl> <68b821ac-d71f-4be5-8dca-ae94db332630@gmail.com>
 <BLU436-SMTP208CF2757B67BA061C8EEADE2580@phx.gbl> <20160603101659.D466A1A81FC5@dd1730.kasserver.com>
 <6d448fd8-8fda-d795-accb-6b96cd128ccd@gmail.com> <BLU436-SMTP1304B21C2B677B1455A9E54E2590@phx.gbl>
 <652fdc5a-a164-2054-ed61-305a2b72330a@gmail.com> <BLU436-SMTP97AAE59E20D9AF3436B732E2590@phx.gbl>
 <c2609544-31cb-d699-4352-6e5497ee1d9b@gmail.com> <20160603142421.346B81A81725@dd1730.kasserver.com>
 <9814df22-9854-616b-bf02-d0742efefaff@gmail.com> <20160603145857.8413F1A8323C@dd1730.kasserver.com>
 <1fb072b3-9b9e-1dfd-6b39-7875587b6c7d@seld.be> <5751B50F.2090003@garfieldtech.com>
 <BLU436-SMTP130242DCE403FFB527B7F3BE2590@phx.gbl> <CANUQDCgu9sgOpSsoukj_PpDk7PPV0vnMuq3wwUj-okJwZuT9Qw@mail.gmail.com>
 <BLU436-SMTP8648B1BCE09FBF02700F20E25A0@phx.gbl>
Date: Sat, 4 Jun 2016 15:48:03 +0200
Message-ID: <CANUQDCgnxTUyT3688cdO999VjaTdSk4rq2wcQr6dJX7Gds8wFA@mail.gmail.com>
To: Bob Weinand <bobwei9@hotmail.com>
Cc: Larry Garfield <larry@garfieldtech.com>, PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a114a54baa57f40053474169b
Subject: Re: [PHP-DEV] [RFC] [PRE-VOTE] Union types
From: me@kelunik.com (Niklas Keller)

--001a114a54baa57f40053474169b
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

>
> Massive is a nice hyperbole here...
> Sure, you can check it manually=E2=80=A6 but why not just always check it=
 manually
> then?
> You then loose possibilities to reflect on it, have static analysis rely
> on code only [currently you always have to check docblocks when it's not
> declared; definitely not an option for e.g. Optimizer], and a single
> signature is generally easier to parse for a human.
>

Talking about reflection, I'm not happy with the currently proposed
solution.

> ReflectionType::__toString() will now provide a full union type as
string; e.g. =E2=80=9Cint | float | NumberObject=E2=80=9D.

That requires libraries like Auryn to manually parse that string now. It's
no longer possible to directly use __toString to get the class name. Isn't
there a better solution?

What about ReflectionType::isBuiltin()? What will it return? Just false?
True if only built in types are used?

I think allowsNull can be handled as is.

See https://3v4l.org/int0g#v700.


> Also, I don't believe it's the languages task to put arbitrary limitation=
s
> on this. If a library does this, that's the libraries problem. But a
> language should not  do that and try to support full typing. We've decide=
d
> to make PHP (opt-in) typed on function boundaries (and eventually soon on
> property storage boundaries), so we should also finish what we committed =
to
> instead of putting something half-arsed forward.
>
> For Aerys\Host it could also be solved with an interface that just doesn'=
t
> have any methods. With the disadvantage of callable not being in the same
> signature anymore.
>
>
> As you say, disadvantage of callable. Also, it requires you to inverse
> responsibilities. You'd have to specify a common super-interface on every
> single fundamentally unrelated interface (which are only indirectly relat=
ed
> by the fact that they receive common handling in a single place). That's =
a
> clear anti-pattern.
> Additionally, this is only possible if you are actually in control on
> these classes and can change them. If you pull them from a library, no
> chance.
>
> Bob
>

--001a114a54baa57f40053474169b--