Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:93716
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain zend.com designates 207.46.100.123 as permitted sender)
To: Benjamin Eberlei <kontakt@beberlei.de>
References: <CY1PR0201MB1786C24A2569B71BB6C716FBBF470@CY1PR0201MB1786.namprd02.prod.outlook.com>
 <CAEPJdunFD3975bJVWVLVuKwxkF=r_jDXXEh-2omt1BCLzebafA@mail.gmail.com>
CC: PHP internals list <internals@lists.php.net>
Message-ID: <ad2b2db8-422d-b711-cfc9-b252a61a3e34@zend.com>
Date: Thu, 2 Jun 2016 15:04:58 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.1.0
MIME-Version: 1.0
In-Reply-To: <CAEPJdunFD3975bJVWVLVuKwxkF=r_jDXXEh-2omt1BCLzebafA@mail.gmail.com>
Content-Type: multipart/alternative;
	boundary="------------4174550EDD4AB978265A5BEA"
SpamDiagnosticOutput: 1:23
SpamDiagnosticMetadata: NSPM
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Jun 2016 12:05:16.7382 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR0201MB1792
Subject: Re: [PHP-DEV] [RFC] Replace "Missing argument" warning with "Too few
 arguments" exception
From: dmitry@zend.com (Dmitry Stogov)

--------------4174550EDD4AB978265A5BEA
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit



On 06/02/2016 02:42 PM, Benjamin Eberlei wrote:
>
>
> On Wed, Jun 1, 2016 at 12:55 PM, Dmitry Stogov <dmitry@zend.com 
> <mailto:dmitry@zend.com>> wrote:
>
>     hi,
>
>
>     Please take a look into the proposal.
>
>
>     https://wiki.php.net/rfc/too_few_args
>
>
>     The RFC is extremely simple (both proposal and implementation) and
>     almost completely described by the email subject.
>
>     I think, this mini-RFC doesn't need 2-weeks discussion period, so
>     I'm going to start the vote on next week.
>
>
> Quick question, I think the error message might be a little confusing 
> asking for "exactly $n" parameters, because it could be a variadic 
> function using func_get_args(), shouldn't the message be?
>
> throw Error("Too few arguments to function %s(), 0 passed in %s on 
> line %d and at least %d expected")
"exactly" is going to be used for functions without variadic arguments 
and arguments with default values.
In that cases PHP will write "at least".
See the patch 
https://github.com/php/php-src/pull/1928/files#diff-3054389ad750ce9a9f5895cd6d27800fR4753

This is similar to other PHP error messages.

     zend_internal_type_error(ZEND_ARG_USES_STRICT_TYPES(), "%s%s%s() 
expects %s %d parameter%s, %d given",
         class_name, \
         class_name[0] ? "::" : "", \
         ZSTR_VAL(active_function->common.function_name),
         min_num_args == max_num_args ? "exactly" : num_args < 
min_num_args ? "at least" : "at most",
         num_args < min_num_args ? min_num_args : max_num_args,
         (num_args < min_num_args ? min_num_args : max_num_args) == 1 ? 
"" : "s",
         num_args);


>
> This only changes the case where the passed arguments are smaller than 
> the required ones or not? This is acceptable BC, but passing more 
> arguments should still not be an error.
Of course.

Thanks. Dmitry.

>
>
>     Thanks. Dmitry.
>
>


--------------4174550EDD4AB978265A5BEA--