Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:93714
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain beberlei.de from 74.125.82.44 cause and error)
MIME-Version: 1.0
In-Reply-To: <CY1PR0201MB1786C24A2569B71BB6C716FBBF470@CY1PR0201MB1786.namprd02.prod.outlook.com>
References: <CY1PR0201MB1786C24A2569B71BB6C716FBBF470@CY1PR0201MB1786.namprd02.prod.outlook.com>
Date: Thu, 2 Jun 2016 13:43:20 +0200
Message-ID: <CAEPJduk_WpSjvDiTb9bsEr=Nhk+9+YeURrapJ3+zETJqKaGBEg@mail.gmail.com>
To: PHP internals <internals@lists.php.net>
Cc: Nikita Popov <nikic@php.net>
Content-Type: multipart/alternative; boundary=001a11424752ecfce305344a1c83
Subject: Re: [PHP-DEV] [RFC] Replace "Missing argument" warning with "Too few
 arguments" exception
From: kontakt@beberlei.de (Benjamin Eberlei)

--001a11424752ecfce305344a1c83
Content-Type: text/plain; charset=UTF-8

On Wed, Jun 1, 2016 at 12:55 PM, Dmitry Stogov <dmitry@zend.com> wrote:

> hi,
>
>
> Please take a look into the proposal.
>
>
> https://wiki.php.net/rfc/too_few_args
>
>
> The RFC is extremely simple (both proposal and implementation) and almost
> completely described by the email subject.
>
> I think, this mini-RFC doesn't need 2-weeks discussion period, so I'm
> going to start the vote on next week.
>

Quick question, I think the error message might be a little confusing
asking for "exactly $n" parameters, because it could be a variadic function
using func_get_args(), shouldn't the message be?

throw Error("Too few arguments to function %s(), 0 passed in %s on line %d
and at least %d expected")

This only changes the case where the passed arguments are smaller than the
required ones or not? This is acceptable BC, but passing more arguments
should still not be an error.

>
>
> Thanks. Dmitry.
>

--001a11424752ecfce305344a1c83--