Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:93710 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 56963 invoked from network); 2 Jun 2016 08:41:23 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 2 Jun 2016 08:41:23 -0000 Authentication-Results: pb1.pair.com header.from=rowan.collins@gmail.com; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=rowan.collins@gmail.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 74.125.82.47 as permitted sender) X-PHP-List-Original-Sender: rowan.collins@gmail.com X-Host-Fingerprint: 74.125.82.47 mail-wm0-f47.google.com Received: from [74.125.82.47] ([74.125.82.47:36929] helo=mail-wm0-f47.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 39/C0-49784-331FF475 for ; Thu, 02 Jun 2016 04:41:23 -0400 Received: by mail-wm0-f47.google.com with SMTP id z87so60068733wmh.0 for ; Thu, 02 Jun 2016 01:41:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=subject:references:to:from:message-id:date:user-agent:mime-version :in-reply-to:content-transfer-encoding; bh=qL3lO22i073zpgBqoaYJ7GYj5udgn4uGtbhHlo5ipn4=; b=XgZgyUCK3Tk89QmigkFyZQ+5Ri15fRoJ5fZhnz+6W0kDVIYa4pGm4RrIGbsmGs/ged s/vHZR8Rm+G+Xk/ikUge7aXTiVbY2SKxjh0kTPyJa1/TJwmJjoEJ+BCwjf/6V5bcrfne 7Bn5MbElBcjHENaf3bqPopl6vx+EdSLDAL0c99fVgH0h6VU8Mjo5NmREh74hi4WlxXaX cr0xdFbhqhACkwhQhvfTG1NtqjJbyf8Q8Ul0tBAQ0mLBT9/oXxzo7GYXGo3xgI92oaIt +LU9Aed+IpzYTH+nTTfHZPatxcjVBh8jyTaCnqs8iOMYAU7X7RtB6jcLFqLnD21Djg1M 7UJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:references:to:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=qL3lO22i073zpgBqoaYJ7GYj5udgn4uGtbhHlo5ipn4=; b=QWEh1FSq0wd0zFpfVMBAwFpFK5MIp7OIvUNmkUhFGna1nVnOhZeBRKt09F5Br95cyF ootZPe/09Tm1uNVb7/DCZOlDN9Tud3qvqtWlYdv6a/n08qpeej3A1wS+wUfXe0MjL+b0 vhuAAqBdMGQZz59TcTnsiBzyAOziI20ge6mYdm9AIcP1u4W5+btZCZ0PUd2He3Xpl773 uR4sN+L+fcWr9iqRtmCLQ1a/PoqhqmjL8sgvl6hat23aegTbORHBydDszoiVwjPUMyft VQkmFCnoLruYEQdRXqo628rR1tiUvOmFGGj5rJUUibTBsAWspbrbE9gNipS9TGqj7ydu 1gTg== X-Gm-Message-State: ALyK8tLWJfucELS8SzBMOz4cuQ9t636f2ebqss9wiBug7I0altJfdUNVx697C9cl/Rr8pQ== X-Received: by 10.28.142.82 with SMTP id q79mr26786514wmd.88.1464856880182; Thu, 02 Jun 2016 01:41:20 -0700 (PDT) Received: from [192.168.0.98] ([93.188.182.58]) by smtp.gmail.com with ESMTPSA id kd7sm49806865wjc.33.2016.06.02.01.41.19 for (version=TLSv1/SSLv3 cipher=OTHER); Thu, 02 Jun 2016 01:41:19 -0700 (PDT) References: <71e88084-27ae-094f-50b8-993202c83501@gmail.com> <18C0A218-B3C0-4E69-9C03-C2C8C407D2FD@trowski.com> To: PHP internals Message-ID: Date: Thu, 2 Jun 2016 09:39:01 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0 MIME-Version: 1.0 In-Reply-To: <18C0A218-B3C0-4E69-9C03-C2C8C407D2FD@trowski.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] [RFC] Replace "Missing argument" warning with "Too few arguments" exception From: rowan.collins@gmail.com (Rowan Collins) On 02/06/2016 00:19, Aaron Piotrowski wrote: > >> On Jun 1, 2016, at 3:56 PM, Rowan Collins wrote: >> >> On 01/06/2016 19:36, Aaron Piotrowski wrote: >>> While this might be considered a BC break, I can't imagine there's an actual code out there relying on suppressing the warning just to call a function without enough arguments. I see no problem putting this change in 7.1. >> >> I think you're overestimating how much people care about their code running without warnings. You don't have to suppress anything, just lazily ignore warnings, or log them to a file you never get round to reading. It *might* be that most users spot and act on the warnings, but I'm not sure how we could know that with any confidence. >> > > Perhaps I'm overestimating how much people care about eliminating warnings, but I doubt many functions work as intended without being supplied all required arguments. The few situations where code worked as intended when too few arguments were provided to a function are fragile and should be fixed. This change will better alert users to those problems. Sure, but "a good thing in the long run" is not the opposite of "BC break". If people upgrade to PHP 7.1 and get a load of errors, they will just delay adoption of that version. That is not a risk that should be dismissed lightly, IMHO. Regards, -- Rowan Collins [IMSoP]