Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:93680
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.218.46 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAJF_ukW5tjZP7WeB0dxa6LyFQA2Nk7mFRX80TkYnFm=e1H5mtA@mail.gmail.com>
References: <CAF1yvAQpOYF2JOZ2PYfofh4zQO5hgvBgnZBX_sFptgSoXCq4-A@mail.gmail.com>
	<CAJF_ukW5tjZP7WeB0dxa6LyFQA2Nk7mFRX80TkYnFm=e1H5mtA@mail.gmail.com>
Date: Wed, 1 Jun 2016 09:47:30 -0600
Message-ID: <CAObuZdv7SW9uf-H232bQwcNfaxY+E9Z01vOU5rzSVRJOzRSYOg@mail.gmail.com>
To: Matt Fonda <matthewfonda@gmail.com>
Cc: Jesse Schalken <me@jesseschalken.com>, PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a1137dd4842c3cb053439682f
Subject: Re: [PHP-DEV] Set object properties inline
From: derokorian@gmail.com (Ryan Pallas)

--001a1137dd4842c3cb053439682f
Content-Type: text/plain; charset=UTF-8

On Wed, Jun 1, 2016 at 9:37 AM, Matt Fonda <matthewfonda@gmail.com> wrote:
>
>
> Hi Jesse,
>
> It's fairly straightforward to implement a function that does this in
> userland, for example something like the following:
>
> function f($fqcn, $args) {
>     $instance = new $fqcn;
>     foreach ($args as $key => $value) {
>         $instance->$key = $value;
>     }
>     return $instance;
> }
> ...
> $this->fooMethod(
>     $arg1,
>     $arg2,
>     f('FooParams', [
>         'prop1' => ...,
>         'prop2' => ...,
>         'prop3' => f('Obj1', [
>             'prop1' => ...,
>             'prop2' => ...,
>         ],
>     ])
> );
>
> You may also use the approach Peter suggested. As such, I don't think
> introducing a new syntax for it is necessary.
>

I disagree here. This lets you add dynamic properties accidentally (by
putting too many entries in the array or misspelling a property as a key),
this method does not let IDEs help you with the construction of the array,
or even what's valid for each value in that array and doesn't provide any
language level protection against misspelled properties. Of course, for the
last point, I'm assuming that this idea works like the following:

class Foo {
   public $prop1;
}

new Foo () {
    porp1 = 'foo' // undefined property error of some sort
};


> Best,
> --Matt
>

--001a1137dd4842c3cb053439682f--