Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:93673
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 74.125.82.46 as permitted sender)
To: internals@lists.php.net
References: <CY1PR0201MB1786C24A2569B71BB6C716FBBF470@CY1PR0201MB1786.namprd02.prod.outlook.com>
Message-ID: <1228b754-6687-bba2-d251-a8d8586ac107@gmail.com>
Date: Wed, 1 Jun 2016 12:33:19 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.1.0
MIME-Version: 1.0
In-Reply-To: <CY1PR0201MB1786C24A2569B71BB6C716FBBF470@CY1PR0201MB1786.namprd02.prod.outlook.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] [RFC] Replace "Missing argument" warning with "Too few
 arguments" exception
From: rowan.collins@gmail.com (Rowan Collins)

On 01/06/2016 11:55, Dmitry Stogov wrote:
> hi,
>
>
> Please take a look into the proposal.
>
>
> https://wiki.php.net/rfc/too_few_args
>
>
> The RFC is extremely simple (both proposal and implementation) and almost completely described by the email subject.
>
> I think, this mini-RFC doesn't need 2-weeks discussion period, so I'm going to start the vote on next week.


I like the concept behind this, but I worry it might have a rather large 
BC impact. Like removing call-time pass-by-reference, there may be a lot 
of long-untouched code that needs fixing to work within this constraint. 
I'm not even sure how easy it would be for static analysis to identify 
these cases. I guess on the flip-side, people will *probably* have 
Warnings displayed or logged already...

The RFC would also benefit from more discussion of the current behaviour 
in different cases:

function foo($a) {}
foo(); // Warning

function bar(A $a) {}
bar(); // Error

function baz(A $a=null) {}
baz(); // OK

function quux(?A $a) {}
quux(); // Not sure. Error?

function wibble(int $a) {}
wibble(); // Error (regardless of strict_types, I think)

function wobble(?int $a) {}
wobble(); // Error?

Any other cases?

Certainly, making these consistent would be nice, but like a lot of 
consistency, does it come at too high a price?

Regards,
-- 
Rowan Collins
[IMSoP]