Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:93640
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 74.125.82.47 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAF+90c-yWvM1Yn-q0u6MQt6eOf3ADn7GagizkqL2Tsq3JQCmFA@mail.gmail.com>
References: <CAJaRsPtPT0Jtn5MNnMuEO4o79oj1Anw63v1PdKhuVG4CD2qw-g@mail.gmail.com>
 <CADyq6sLuzfJoE5dG795Er1Dq2ThWeGxS7taMwyo1qbn-zejxSg@mail.gmail.com>
 <CAJaRsPsGqskOts8E=3YYa2GctgfO65tuZQL3i6a6zXGPB=vf0g@mail.gmail.com> <CAF+90c-yWvM1Yn-q0u6MQt6eOf3ADn7GagizkqL2Tsq3JQCmFA@mail.gmail.com>
Date: Mon, 30 May 2016 22:21:59 +0200
Message-ID: <CADyq6sLS9M_Bgvj=6djRc9h-cE+BTbbA2MjN1FyezXGaus_V5w@mail.gmail.com>
To: Nikita Popov <nikita.ppv@gmail.com>
Cc: "Colin O'Dell" <colinodell@gmail.com>, PHP Internals <internals@lists.php.net>, 
	Jeremy Mikola <jmikola@gmail.com>
Content-Type: multipart/alternative; boundary=001a114ba6e466994f05341503ce
Subject: Re: [PHP-DEV] [RFC Discussion] array_change_keys()
From: ocramius@gmail.com (Marco Pivetta)

--001a114ba6e466994f05341503ce
Content-Type: text/plain; charset=UTF-8

I benchmarked this more carefully at
https://github.com/Ocramius/array_change_keys-benchmark - the results are
indeed not matching what is represented in the RFC.

Specifically, `array_change_keys` has performance that is comparable to
`array_combine` + `array_map`, and looping is still faster by at least 35%.

This is mostly due to the function calls, which is what I expected.

Feel free to patch the benchmarks, should they be buggy. Also feel free to
add more scenarios.

Cheers,

Marco Pivetta

http://twitter.com/Ocramius

http://ocramius.github.com/

On 30 May 2016 at 20:55, Nikita Popov <nikita.ppv@gmail.com> wrote:

> On Mon, May 30, 2016 at 3:40 AM, Colin O'Dell <colinodell@gmail.com>
> wrote:
>
>> Marco,
>>
>>
>> >  1. could you also provide the code for the benchmarks? I'd gladly
>> measure
>> > them with an accurate tool
>> >
>>
>> Yeah that would be great!  Here's the benchmark I was using:
>> https://gist.github.com/colinodell/872c1f0c92351af687347c0c8be4f253
>
>
> I can't tell you what exactly this is benchmarking (probably a mix of
> various caches ranging from the Zend MM, via the kernel, to the CPU). The
> only thing it's pretty certainly not benchmarking are different
> implementations of changing keys :) You're basically just penalizing
> whichever implementation comes first.
>
> For a more representative benchmark, reduce the number of elements by a
> factor of 10 or hundred. In which case foreach should win at least against
> the array_map+array_combine implementation.
>
> Regards,
> Nikita
>

--001a114ba6e466994f05341503ce--