Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:93637
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.161.172 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAJaRsPsGqskOts8E=3YYa2GctgfO65tuZQL3i6a6zXGPB=vf0g@mail.gmail.com>
References: <CAJaRsPtPT0Jtn5MNnMuEO4o79oj1Anw63v1PdKhuVG4CD2qw-g@mail.gmail.com>
	<CADyq6sLuzfJoE5dG795Er1Dq2ThWeGxS7taMwyo1qbn-zejxSg@mail.gmail.com>
	<CAJaRsPsGqskOts8E=3YYa2GctgfO65tuZQL3i6a6zXGPB=vf0g@mail.gmail.com>
Date: Mon, 30 May 2016 20:55:57 +0200
Message-ID: <CAF+90c-yWvM1Yn-q0u6MQt6eOf3ADn7GagizkqL2Tsq3JQCmFA@mail.gmail.com>
To: "Colin O'Dell" <colinodell@gmail.com>
Cc: Marco Pivetta <ocramius@gmail.com>, PHP Internals <internals@lists.php.net>, 
	Jeremy Mikola <jmikola@gmail.com>
Content-Type: multipart/alternative; boundary=001a113ce0e08c6fe5053413ce27
Subject: Re: [PHP-DEV] [RFC Discussion] array_change_keys()
From: nikita.ppv@gmail.com (Nikita Popov)

--001a113ce0e08c6fe5053413ce27
Content-Type: text/plain; charset=UTF-8

On Mon, May 30, 2016 at 3:40 AM, Colin O'Dell <colinodell@gmail.com> wrote:

> Marco,
>
>
> >  1. could you also provide the code for the benchmarks? I'd gladly
> measure
> > them with an accurate tool
> >
>
> Yeah that would be great!  Here's the benchmark I was using:
> https://gist.github.com/colinodell/872c1f0c92351af687347c0c8be4f253


I can't tell you what exactly this is benchmarking (probably a mix of
various caches ranging from the Zend MM, via the kernel, to the CPU). The
only thing it's pretty certainly not benchmarking are different
implementations of changing keys :) You're basically just penalizing
whichever implementation comes first.

For a more representative benchmark, reduce the number of elements by a
factor of 10 or hundred. In which case foreach should win at least against
the array_map+array_combine implementation.

Regards,
Nikita

--001a113ce0e08c6fe5053413ce27--