Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:93629
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 74.125.82.53 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAJaRsPtPT0Jtn5MNnMuEO4o79oj1Anw63v1PdKhuVG4CD2qw-g@mail.gmail.com>
References: <CAJaRsPtPT0Jtn5MNnMuEO4o79oj1Anw63v1PdKhuVG4CD2qw-g@mail.gmail.com>
Date: Mon, 30 May 2016 00:18:52 +0200
Message-ID: <CADyq6sLuzfJoE5dG795Er1Dq2ThWeGxS7taMwyo1qbn-zejxSg@mail.gmail.com>
To: "Colin O'Dell" <colinodell@gmail.com>
Cc: PHP Internals <internals@lists.php.net>, Jeremy Mikola <jmikola@gmail.com>
Content-Type: multipart/alternative; boundary=001a1141ef9c8a32dd05340287c3
Subject: Re: [PHP-DEV] [RFC Discussion] array_change_keys()
From: ocramius@gmail.com (Marco Pivetta)

--001a1141ef9c8a32dd05340287c3
Content-Type: text/plain; charset=UTF-8

A bit skeptic here:

 1. could you also provide the code for the benchmarks? I'd gladly measure
them with an accurate tool
 2. do we really need another array function that is basically an
`array_combine(array_map($someFunc, array_keys($arr)), $arr)`?
 3. and... do we really want another function that accepts arrays and not
generic Traversable (and therefore also generators)?
 4. what is the real-world benefit over just
`array_combine(array_map($someFunc, array_keys($arr)), $arr)`, except for
the two additional function calls here?

Cheers,



Marco Pivetta

http://twitter.com/Ocramius

http://ocramius.github.com/

On 29 May 2016 at 15:13, Colin O'Dell <colinodell@gmail.com> wrote:

> Hello everyone,
>
> I'd like to introduce a new RFC for your consideration and discussion:
> https://wiki.php.net/rfc/array_change_keys  This would add a new function
> named array_change_keys() which simplifies the process of re-keying an
> array.
>
> PHP currently has an array_change_key_case() method, but this only allows
> keys to be changed to upper- or lower-case; no method exists to change the
> keys to some custom user-defined value.  Although it's absolutely possible
> to accomplish this without a special function, the alternate approaches
> have several drawbacks:
>
>  - Slower execution time compared to the proposed implementation.
>  - Multiple lines and/or function calls are required.
>  - Harder to understand the code's purpose with a quick glance.
>  - The result of a "foreach" approach cannot be passed into another
> function without using an intermediate variable.
>
> A working implementation has been included with the RFC (huge thanks to
> Jeremy Mikola for the heavy lifting here!)  I've also requested this patch
> be added to 3v4l.org; I'll notify everyone if/when that happens.
>
> I'd greatly appreciate if you could review this RFC and let me know your
> thoughts.  I'd be happy to answer any questions you might have.
>
> Regards,
>
> Colin O'Dell
>

--001a1141ef9c8a32dd05340287c3--