Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:93623
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain nunninger.info from 87.106.55.207 cause and error)
To: Colin O'Dell <colinodell@gmail.com>,
 PHP Internals <internals@lists.php.net>
References: <CAJaRsPtPT0Jtn5MNnMuEO4o79oj1Anw63v1PdKhuVG4CD2qw-g@mail.gmail.com>
Cc: jmikola@gmail.com
Message-ID: <574AF60A.6070908@nunninger.info>
Date: Sun, 29 May 2016 16:00:42 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.8.0
MIME-Version: 1.0
In-Reply-To: <CAJaRsPtPT0Jtn5MNnMuEO4o79oj1Anw63v1PdKhuVG4CD2qw-g@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] [RFC Discussion] array_change_keys()
From: thomas@nunninger.info (Thomas Nunninger)

Hello,

shouldn't it be possible to return null as new key? That way you say: 
Use the next free integer index.

Not sure if returning null is wanted (as it could hide errors in the 
callback) or needed in some real world use cases. But it would be more 
in sync with $a[] = ...

Regards

Thomas

On 05/29/2016 03:13 PM, Colin O'Dell wrote:
> Hello everyone,
>
> I'd like to introduce a new RFC for your consideration and discussion:
> https://wiki.php.net/rfc/array_change_keys  This would add a new function
> named array_change_keys() which simplifies the process of re-keying an
> array.
>
> PHP currently has an array_change_key_case() method, but this only allows
> keys to be changed to upper- or lower-case; no method exists to change the
> keys to some custom user-defined value.  Although it's absolutely possible
> to accomplish this without a special function, the alternate approaches
> have several drawbacks:
>
>   - Slower execution time compared to the proposed implementation.
>   - Multiple lines and/or function calls are required.
>   - Harder to understand the code's purpose with a quick glance.
>   - The result of a "foreach" approach cannot be passed into another
> function without using an intermediate variable.
>
> A working implementation has been included with the RFC (huge thanks to
> Jeremy Mikola for the heavy lifting here!)  I've also requested this patch
> be added to 3v4l.org; I'll notify everyone if/when that happens.
>
> I'd greatly appreciate if you could review this RFC and let me know your
> thoughts.  I'd be happy to answer any questions you might have.
>
> Regards,
>
> Colin O'Dell
>