Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:93572
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain thefsb.org designates 67.192.241.147 as permitted sender)
User-Agent: Microsoft-MacOutlook/14.6.4.160422
Date: Thu, 26 May 2016 12:44:19 -0400
To: Thomas Bley <mails@thomasbley.de>,
	<ajf@ajf.me>,
	<internals@lists.php.net>
Message-ID: <D36C9A9E.6E809%fsb@thefsb.org>
Thread-Topic: [PHP-DEV] [RFC][Vote] Typed Properties
References: <20160525215208.034FC1A801B3@dd1730.kasserver.com>
 <e194be7d-2d72-945c-b8de-245e91f6f239@thefsb.org>
 <20160526144023.2A2A11A800A7@dd1730.kasserver.com>
In-Reply-To: <20160526144023.2A2A11A800A7@dd1730.kasserver.com>
Mime-version: 1.0
Content-type: text/plain;
	charset="UTF-8"
Content-transfer-encoding: 7bit
Subject: Re: [PHP-DEV] [RFC][Vote] Typed Properties
From: fsb@thefsb.org (Tom Worster)

Hi Thomas,

On the face of it, I'm not enthusiastic to introduce new magic numbers
(which would be false, 0, 0.0, "", and [], right?) that PHP assigns when
coercing a typed, uninitialized property read by a file in liberal mode.

This is like taking the most confusing thing about 7.0's dual-mode, scalar
type declaration of function arguments and boosting the confusion power. I
would want a new name for this complement-of-strict mode. "Weak" and
"liberal" don't quite do it. Promiscuous mode? ;)

Tom


On 5/26/16, 10:40 AM, "Thomas Bley" <mails@thomasbley.de> wrote:

>I think strict_types=1 should give a fatal error for accessing
>non-initialized typed properties, instead of notice.
>Example:
>
>declare(strict_types=1);
>
>class A {
>	public int $x;
>	public ?int $y = null;
>	public int $z = 42;
>	public ?int $u;
>	public ?datetime $v;
>	public datetime $w;
>}
>
>$a = new A;
>var_dump($a->x); // Fatal error, uninitialized...
>var_dump($a->y); // null
>var_dump($a->z); // 42
>var_dump(isset($a->z)); // true
>unset($a->z);
>var_dump(isset($a->z)); // false
>var_dump($a->z); // Fatal error, uninitialized...
>var_dump($a->u); // Fatal error, uninitialized...
>var_dump($a->v); // Fatal error, uninitialized...
>var_dump($a->w); // Fatal error, uninitialized...
>
>var_dump(isset($a->x)); // false
>var_dump(isset($a->y)); // false
>var_dump(isset($a->u)); // false
>var_dump(isset($a->v)); // false
>var_dump(isset($a->w)); // false
>
>Regards
>Thomas
>
>Tom Worster wrote on 26.05.2016 15:53:
>
>> On 5/25/16 5:52 PM, Thomas Bley wrote:
>>> I'm not seeing a problem here:
>>>
>>> class A {
>>>   public int $x;
>>>   public ?int $y = null;
>>>   public int $z = 42;
>>>   public ?int $u;
>>>   public ?datetime $v;
>>>   public datetime $w;
>>> }
>>>
>>> $a = new A;
>>> var_dump($a->x); // 0 + notice
>>> var_dump($a->y); // null
>>> var_dump($a->z); // 42
>>> var_dump(isset($a->z)); // true
>>> unset($a->z);
>>> var_dump(isset($a->z)); // false
>>> var_dump($a->z); // 0 + notice
>>> var_dump($a->u); // null + notice
>>> var_dump($a->v); // null + notice
>>> var_dump($a->w); // Fatal error, uninitialized...
>>>
>>> var_dump(isset($a->x)); // false
>>> var_dump(isset($a->y)); // false
>>> var_dump(isset($a->u)); // false
>>> var_dump(isset($a->v)); // false
>>> var_dump(isset($a->w)); // false
>> 
>> Is the file containing these examples in liberal mode?
>> 
>> What changes if declare(strict_types=1) precedes $a = new A;?
>> 
>> Tom
>> 
>