Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:93491
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain zend.com designates 65.55.169.133 as permitted sender)
To: Joe Watkins <pthreads@pthreads.org>, PHP internals
	<internals@lists.php.net>, Phil Sturgeon <pjsturgeon@gmail.com>, Bob Weinand
	<bwoebi@php.net>
Thread-Topic: [PHP-DEV] [RFC][Vote] Typed Properties
Thread-Index: AQHRsl29xlQFrvOFJkSnB4pG0wOhsp/Icluf
Date: Tue, 24 May 2016 19:04:34 +0000
Message-ID: <BY2PR0201MB17845690B6386D75AF4C3D79BF4F0@BY2PR0201MB1784.namprd02.prod.outlook.com>
References: <CAL=_i_mcJoFnPgeU5FQCJN=SDYnNK7Jz8zoVMv9EMuWaGRYSMg@mail.gmail.com>
In-Reply-To: <CAL=_i_mcJoFnPgeU5FQCJN=SDYnNK7Jz8zoVMv9EMuWaGRYSMg@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
spamdiagnosticoutput: 1:23
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-originalarrivaltime: 24 May 2016 19:04:34.6244
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 32210298-c08b-4829-8097-6b12c025a892
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR0201MB1783
Subject: Re: [PHP-DEV] [RFC][Vote] Typed Properties
From: dmitry@zend.com (Dmitry Stogov)

Hi Joe,

I've add implementation for nullable typed properties (as they fit into the=
 patch design), but RFC missed any description of nullable properties.
See tests  Zend/tests/type_declarations/typed_properties_047.phpt,  Zend/te=
sts/type_declarations/typed_properties_048.phpt,  Zend/tests/type_declarati=
ons/typed_properties_049.phpt

I'm not sure, if this is what the voters expect. At least I don't like the =
facts that "?int $foo;" declares uninitialized property; "?int $foo =3D NUL=
L" may be unset() and became uninitialized; and it's an open question if "i=
nt $foo =3D NULL;" should be supported as nullable. Inheritance rules for t=
yped nullable properties are also missed.

Personally, I think the RFC was moved into voting state too early (without =
good enough implementation, and with missing  topics).
The current implementation is better (performance penalty reduced to ~2%), =
but still have unsolved problems.

May be it's better to cancel voting, solve problems, finish the implementat=
ion and add missing questions into RFC...
I'm going to help with implementation in any case, but we should agree on w=
hat we are doing.

Thanks. Dmitry.

________________________________________
From: Joe Watkins <pthreads@pthreads.org>
Sent: Friday, May 20, 2016 9:05:34 AM
To: PHP internals; Phil Sturgeon
Subject: [PHP-DEV] [RFC][Vote] Typed Properties

Morning internals,

    Since we have our answer on nullable types, typed properties can now go
to vote.

    https://wiki.php.net/rfc/typed-properties#vote

    Note that, support for nullability as RFC'd will be merged when the
implementation for nullable_types is merged into master.

    Please participate.

Cheers
Joe