Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:93481 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 71812 invoked from network); 24 May 2016 09:40:15 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 24 May 2016 09:40:15 -0000 Authentication-Results: pb1.pair.com smtp.mail=pierre.php@gmail.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=pierre.php@gmail.com; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.218.46 as permitted sender) X-PHP-List-Original-Sender: pierre.php@gmail.com X-Host-Fingerprint: 209.85.218.46 mail-oi0-f46.google.com Received: from [209.85.218.46] ([209.85.218.46:35116] helo=mail-oi0-f46.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id E0/26-37212-E7124475 for ; Tue, 24 May 2016 05:40:14 -0400 Received: by mail-oi0-f46.google.com with SMTP id w184so10558666oiw.2 for ; Tue, 24 May 2016 02:40:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc; bh=PoCB6GkWo/gxwG6rjVgoCnVnAO7NnZyJmF2cIEgokd8=; b=Md1lHfwwYSQgtUnJ54s8oDl9jFpm7oNON0DaDsilKxt//xwHzvOAewLwxQHV6he8g/ ANBknZztsQNfW9R7aOvBJahJXCZbTWzXUmyN3VKZV1u6syf6zy5FMZ19SlYQH5fjRH1W MQIRV3aVfiM2e40B8P7YsgbvTBU3tF6z2wvzMeEeeWorCFckMlR2Ck2L/4OFLWt6oMkB S+50F+WBQYbu5vLevdm8mTsgCe8esr/o21QVA9O03AR6hQOy+Z6GaHe998IXR4OZ63Nx X4fVG5PKmL/7+8X8rNFdcumDLkUqTH3e40EmxsrmdpZJvzphPRTyV/trh5wrdotJMwbv ldyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc; bh=PoCB6GkWo/gxwG6rjVgoCnVnAO7NnZyJmF2cIEgokd8=; b=LOZpRPhl3CHka8b8zCt4z+7HgwALTtn7/bNSplJ7zNlaXFgMRahhAvQ4t1lsdUzXgr FZ+K7IQuLonhRXbDfsZ0fFSodcKazoWptO5lL30zeigYR2A1QEq7IkKOnEVtali+ghyI onjdgR1euz/dtyGa2bgk07OPvbV9aGFCvuYBhUxK67sfytcvaKQuQMQ6AW2EJoHt34Lt PHmN5xFpfJMcPMD0EglswqfKAkm5j1MlsFjZJGJCFu3C8k5joIC4eQo83rt8ULAN/JUp zydhJ7XO+izWa/Cotsv4ONg0JHyDC5/edZVGb3nufA4CZ8TNV3rbTq5fHCbOUjfZGI6C +5TA== X-Gm-Message-State: ALyK8tKrYe0Tuffuwz0i7ulmSMLMZob5HVqoeMAYHr+C2dEGpyY0LtGWxI1XfZ1yKIFxc1I//vQmeUFqyQNh7A== MIME-Version: 1.0 X-Received: by 10.157.44.130 with SMTP id p2mr2186447otb.104.1464082811122; Tue, 24 May 2016 02:40:11 -0700 (PDT) Received: by 10.202.215.193 with HTTP; Tue, 24 May 2016 02:40:10 -0700 (PDT) Received: by 10.202.215.193 with HTTP; Tue, 24 May 2016 02:40:10 -0700 (PDT) In-Reply-To: References: Date: Tue, 24 May 2016 16:40:10 +0700 Message-ID: To: Stas Malyshev Cc: Joe Watkins , Philip Sturgeon , PHP internals , Dmitry Stogov Content-Type: multipart/alternative; boundary=001a113dda0ae12442053393574c Subject: Re: [PHP-DEV] [RFC][Vote] Typed Properties From: pierre.php@gmail.com (Pierre Joye) --001a113dda0ae12442053393574c Content-Type: text/plain; charset=UTF-8 On May 23, 2016 4:09 PM, "Stanislav Malyshev" wrote: > > Hi! > > > The performance effect of this implementation is terrible. > > > > Assignment to typed property is 2.3 times slower. > > Assignment to untyped property in a class with typed properties is 1.8 times slower. > > > > See the benchmark > > https://gist.github.com/dstogov/1b678712adeee51665cdd829195bb800 > > This is not good. I wonder why these tests weren't made before the vote > and results wheren't added in the RFC. Should we make it a standard > practice to do so? Having 2x slowdown on each property access sounds > like a bad idea. Agreed. We added a performance impact section to the rfc template for this exact reason. We do not enforce it. Maybe we should. --001a113dda0ae12442053393574c--