Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:93476
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.220.49 as permitted sender)
To: Dmitry Stogov <dmitry@zend.com>, internals <internals@lists.php.net>
References: <BY2PR0201MB178440ABA11456D96DBBF8B8BF4E0@BY2PR0201MB1784.namprd02.prod.outlook.com>
 <478356f3-cc53-d419-cfea-0a6bbd782031@gmail.com>
 <c35446d0-e5ca-affd-76a8-6567f795c661@zend.com>
Cc: Nikita Popov <nikic@php.net>, Bob Weinand <bwoebi@php.net>,
 Xinchen Hui <laruence@php.net>
Message-ID: <e00d7e23-8388-63d2-8376-aaf02344b3fb@gmail.com>
Date: Tue, 24 May 2016 01:04:53 -0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:45.0)
 Gecko/20100101 Thunderbird/45.1.0
MIME-Version: 1.0
In-Reply-To: <c35446d0-e5ca-affd-76a8-6567f795c661@zend.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] [RFC] Fix inconsistent behavior of $this variable
From: smalyshev@gmail.com (Stanislav Malyshev)

Hi!

> Keeping inconsistent behavior isn't good as well.

It's not good, but it's not also very bad. Nobody really does that, so
whatever happens in these cases is mostly irrelevant.

Did you test performance impact of those changes?

> Actually, $this may be assigned to local variable in run-time only in 3
> places: through $$, extract() and parse_str()/1.

For now, maybe. But every time we do something with local symbol table,
we'd have to do special case for this. E.g., throretically, what if we
wanted to add function to Closure that allows to access to captured
scope - we'd need to special-case $this there. Etc...

> If we remove this checks, we go back to 7.0 behavior - we create a local
> variable $this, that has nothing in common with real internal $this
> stored in EX(This).

That's not good, but maybe we could make them agree in some way?

> In most cases it doesn't show $this in 7.0.

Right. But you're changing 7.0 behavior anyway?

-- 
Stas Malyshev
smalyshev@gmail.com