Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:93473
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain zend.com designates 157.56.110.141 as permitted sender)
To: Stanislav Malyshev <smalyshev@gmail.com>, internals
	<internals@lists.php.net>
References: <BY2PR0201MB178440ABA11456D96DBBF8B8BF4E0@BY2PR0201MB1784.namprd02.prod.outlook.com>
 <478356f3-cc53-d419-cfea-0a6bbd782031@gmail.com>
CC: Nikita Popov <nikic@php.net>, Bob Weinand <bwoebi@php.net>, Xinchen Hui
	<laruence@php.net>
Message-ID: <c35446d0-e5ca-affd-76a8-6567f795c661@zend.com>
Date: Tue, 24 May 2016 10:33:59 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.0
MIME-Version: 1.0
In-Reply-To: <478356f3-cc53-d419-cfea-0a6bbd782031@gmail.com>
Content-Type: multipart/alternative;
	boundary="------------00C0746835A7FCDD216ACEA0"
SpamDiagnosticOutput: 1:23
SpamDiagnosticMetadata: NSPM
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 May 2016 07:34:13.4806 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR0201MB1787
Subject: Re: [PHP-DEV] [RFC] Fix inconsistent behavior of $this variable
From: dmitry@zend.com (Dmitry Stogov)

--------------00C0746835A7FCDD216ACEA0
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit



On 05/24/2016 09:54 AM, Stanislav Malyshev wrote:
> Hi!
>
>> Please review the RFC.
>>
>> It proposes to fix all known inconsistencies related to handling of special $this variable.
>>
>> https://wiki.php.net/rfc/this_var
> What is the reason behind all these changes? Does it serve some bigger
> purpose?
I started from attempt to eliminate second internal way to access $this 
variable.
This disclosed all these inconsistencies.

>   I'm not sure I currently see a reason to go to all these
> lengths. Sure, you can re-assign $this and make things weird. But I
> don't see why it's important to prevent it.
Keeping inconsistent behavior isn't good as well.

>   It seems to add a lot of
> code, including checks in various places that would slow down things
> (and since these checks need to be done in each and every place we deal
> with local variables, it is also a very brittle design - each time we
> change or add anything there we'd need to remember forever to include
> special case for "this").
Actually, $this may be assigned to local variable in run-time only in 3 
places: through $$, extract() and parse_str()/1.
If we remove this checks, we go back to 7.0 behavior - we create a local 
variable $this, that has nothing in common with real internal $this 
stored in EX(This).

>
> Also notes:
> 1. How static __call is a thing? That looks like something that makes no
> sense at all.

The same for me.
I got to know about static __call() and its special behavior from test 
suite. :)
See tests/classes/__call_007.phpt

> 2. Why get_defined_vars() shouldn't show $this?
>

In most cases it doesn't show $this in 7.0.

Thanks. Dmitry.


--------------00C0746835A7FCDD216ACEA0--