Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:93450
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.161.174 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <BY2PR0201MB1784A01C040C1332E4B3D7E8BF4E0@BY2PR0201MB1784.namprd02.prod.outlook.com>
References: <BY2PR0201MB1784296F01E558FF22C48C7ABF4B0@BY2PR0201MB1784.namprd02.prod.outlook.com>
	<CAF+90c_KWrE0PE9p-BWZz9uXaLFUarnbp3h30rN3THz9S7pLjQ@mail.gmail.com>
	<BY2PR0201MB1784A01C040C1332E4B3D7E8BF4E0@BY2PR0201MB1784.namprd02.prod.outlook.com>
Date: Mon, 23 May 2016 18:24:59 +0200
Message-ID: <CAF+90c8NFf2wO4myKtXfUK4GEpUY4ttjS5bePYOKYnYKrNww4g@mail.gmail.com>
To: Dmitry Stogov <dmitry@zend.com>
Cc: Xinchen Hui <xinchen.h@zend.com>, internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=94eb2c088930b90b5b053384e178
Subject: Re: "finally" handling refactoring (Bug #72213)
From: nikita.ppv@gmail.com (Nikita Popov)

--94eb2c088930b90b5b053384e178
Content-Type: text/plain; charset=UTF-8

On Mon, May 23, 2016 at 1:25 PM, Dmitry Stogov <dmitry@zend.com> wrote:

> Thanks for review.
>
> Both problems should be fixed now
> https://gist.github.com/dstogov/0a809891c6a3ac3fac4bd0d9711dd330
>
> Do you see any other problems or a better way to fix this?
>
Your fix for DISCARD_EXCEPTION does not look right to me. It will discard
all exceptions too early. For example:

function test() {
    try {
        throw new Exception(1);
    } finally {
        try {
            try {
            } finally {
                return 42;
            }
        } finally {
            throw new Exception(2);
        }
    }
}

test();

This will now not chain exception 1 and 2, because exception 1 is discarded
at the return statement.

I think this should be handled the same way we do the fast_call dispatch on
return, i.e. when we pop the FAST_CALL from the loop var stack we should
replace it with a DISCARD_EXCEPTION and then pop it after the finally. This
should generate all the necessary DISCARD_EXCEPTION opcodes, and in the
right order.

Nikita

--94eb2c088930b90b5b053384e178--