Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:93443
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain zend.com designates 207.46.100.127 as permitted sender)
To: Nikita Popov <nikita.ppv@gmail.com>
CC: Xinchen Hui <xinchen.h@zend.com>, internals <internals@lists.php.net>
Thread-Topic: "finally" handling refactoring (Bug #72213)
Thread-Index: AQHRsooB/asZC+6F5UyFZdE4B+ax2p/B2ROAgASM9cA=
Date: Mon, 23 May 2016 11:25:14 +0000
Message-ID: <BY2PR0201MB1784A01C040C1332E4B3D7E8BF4E0@BY2PR0201MB1784.namprd02.prod.outlook.com>
References: <BY2PR0201MB1784296F01E558FF22C48C7ABF4B0@BY2PR0201MB1784.namprd02.prod.outlook.com>,<CAF+90c_KWrE0PE9p-BWZz9uXaLFUarnbp3h30rN3THz9S7pLjQ@mail.gmail.com>
In-Reply-To: <CAF+90c_KWrE0PE9p-BWZz9uXaLFUarnbp3h30rN3THz9S7pLjQ@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
spamdiagnosticoutput: 1:23
spamdiagnosticmetadata: NSPM
Content-Type: multipart/alternative;
	boundary="_000_BY2PR0201MB1784A01C040C1332E4B3D7E8BF4E0BY2PR0201MB1784_"
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-originalarrivaltime: 23 May 2016 11:25:14.4491
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 32210298-c08b-4829-8097-6b12c025a892
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR02MB1712
Subject: Re: "finally" handling refactoring (Bug #72213)
From: dmitry@zend.com (Dmitry Stogov)

--_000_BY2PR0201MB1784A01C040C1332E4B3D7E8BF4E0BY2PR0201MB1784_
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

Thanks for review.

Both problems should be fixed now https://gist.github.com/dstogov/0a809891c=
6a3ac3fac4bd0d9711dd330

Do you see any other problems or a better way to fix this?


Thanks. Dmitry.

________________________________
From: Nikita Popov <nikita.ppv@gmail.com>
Sent: Friday, May 20, 2016 4:54:07 PM
To: Dmitry Stogov
Cc: Xinchen Hui; internals
Subject: Re: "finally" handling refactoring (Bug #72213)

On Fri, May 20, 2016 at 2:07 PM, Dmitry Stogov <dmitry@zend.com<mailto:dmit=
ry@zend.com>> wrote:

hi,


Please review the path https://gist.github.com/dstogov/0a809891c6a3ac3fac4b=
d0d9711dd330


I hope, it should completely fix https://bugs.php.net/bug.php?id=3D72213


I'm going to commit this on Monday.


Thanks. Dmitry.

From a quick look:

https://gist.github.com/dstogov/0a809891c6a3ac3fac4bd0d9711dd330#file-bug72=
213-diff-L74 =3D> should this be orig_try_catch_offset?

https://gist.github.com/dstogov/0a809891c6a3ac3fac4bd0d9711dd330#file-bug72=
213-diff-L303 =3D> This assumes that either there's a catch block or a fina=
lly block to go to. However, if we're in the catch block of a try/catch (wi=
thout finally) that may not be true.

Also, this still leaks one exception :(

<?php

function test() {
    try {
        throw new Exception(1);
    } finally {
        try {
            throw new Exception(2);
        } finally {
            return 42;
        }
    }
}

test();

Nikita

--_000_BY2PR0201MB1784A01C040C1332E4B3D7E8BF4E0BY2PR0201MB1784_--