Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:93440 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 59561 invoked from network); 23 May 2016 09:55:25 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 23 May 2016 09:55:25 -0000 Authentication-Results: pb1.pair.com smtp.mail=julienpauli@gmail.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=julienpauli@gmail.com; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 74.125.82.52 as permitted sender) X-PHP-List-Original-Sender: julienpauli@gmail.com X-Host-Fingerprint: 74.125.82.52 mail-wm0-f52.google.com Received: from [74.125.82.52] ([74.125.82.52:35820] helo=mail-wm0-f52.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 09/95-14293-C83D2475 for ; Mon, 23 May 2016 05:55:25 -0400 Received: by mail-wm0-f52.google.com with SMTP id a136so12765049wme.0 for ; Mon, 23 May 2016 02:55:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=6UPdsJszAPLZBVPY4Amtu+DoVRPDhzUlI9h5TzdiCjc=; b=YKKYFW7cagi4Ge16KUPTDEgb47DrDD27hJZZfYmwgWx4J4GDTqZmg+iquSSVM0RBvD 9N5qbBaRoWwyCUaW9TDBfpsv9p7mIQtw+HZ4gW21+LnlgqEcd29huLsuOkM0+ZCQzJEv sDs4158f0Tjm6XNhs7WkHI2P/BK1rZ+K4wpRtn7qt7kzav6RUAplNwa5l64H11lgyGPg UocOyzDo01TIPia3GaPsCAqFbmx48A03doN6amHbB+q2J8PYMjpH058y6p2dPU3xo5z6 EGTXIzrccg+eJysLrHHZnyx2pQgTWPpS8dlsIDeEmfP0kIwyHCSdHaPziJC1GCLC8MF9 RFFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=6UPdsJszAPLZBVPY4Amtu+DoVRPDhzUlI9h5TzdiCjc=; b=XcE9BFi2VirgZofq2gblIOeARDJYSPKTXF/I9w/J6lp7ASAIUka/6tQ4FIWZwadxmp 4YiNWW0aZmOccu591JTTqBjB2kyoOT8lD4Cne50ZFo0rJ6xxlayw3q3/n9mryHXqKypq 6FYNLQ0b6XnxINEfMOQ2frvWgBveJZiykwjxkjwBZ+7gdcqzROpg8TI/B2hEE64MybIB MWnFnnt6PlwO5rfoyMDoLlJ5wHtwwV59nngTD8IiimuUuwExUHk/2Y4WGa4syQakrY9v EQVM+3jlt3WUwr34Pl2eGhqO8Y4TYgp2s54sDXA91KEm36Vt0DxEkDQ12oQWWKYtgUSF IL4Q== X-Gm-Message-State: AOPr4FVQ1yeshNgxpezOuSvYOriQNQjZxsHww1jFt5cPrCqhjBl3XnEcbVI9ij8lOXMRETiHBeStUXz1dcWPWQ== X-Received: by 10.28.30.67 with SMTP id e64mr16772261wme.84.1463997321600; Mon, 23 May 2016 02:55:21 -0700 (PDT) MIME-Version: 1.0 Sender: julienpauli@gmail.com Received: by 10.194.216.4 with HTTP; Mon, 23 May 2016 02:54:41 -0700 (PDT) In-Reply-To: References: Date: Mon, 23 May 2016 11:54:41 +0200 X-Google-Sender-Auth: Ngq10RrKZBDxkDqhMoHcA21-T2k Message-ID: To: Stanislav Malyshev Cc: Dmitry Stogov , Joe Watkins , PHP internals , Phil Sturgeon Content-Type: text/plain; charset=UTF-8 Subject: Re: [PHP-DEV] [RFC][Vote] Typed Properties From: jpauli@php.net (Julien Pauli) On Mon, May 23, 2016 at 11:09 AM, Stanislav Malyshev wrote: > Hi! > >> The performance effect of this implementation is terrible. >> >> Assignment to typed property is 2.3 times slower. >> Assignment to untyped property in a class with typed properties is 1.8 times slower. >> >> See the benchmark >> https://gist.github.com/dstogov/1b678712adeee51665cdd829195bb800 > > This is not good. I wonder why these tests weren't made before the vote > and results wheren't added in the RFC. Should we make it a standard > practice to do so? Having 2x slowdown on each property access sounds > like a bad idea. The question is : * should the vote be an idea-based vote, or integrate the code into the vote ? My vote did not integrate the code, but the feature. The idea is that if the RFC passes, then the feature is agreed, and we still have some time to find a better implementation. If we could not find one, then the feature should be abandoned or post-poned until a new patch. If the new patch changes the implementation, then the RFC should be reopened. My thoughts. Julien.Pauli