Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:93437
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain zend.com designates 207.46.100.148 as permitted sender)
To: Joe Watkins <pthreads@pthreads.org>, PHP internals
	<internals@lists.php.net>, Phil Sturgeon <pjsturgeon@gmail.com>
Thread-Topic: [PHP-DEV] [RFC][Vote] Typed Properties
Thread-Index: AQHRsl29xlQFrvOFJkSnB4pG0wOhsp/GNLQWgAAGCZ8=
Date: Mon, 23 May 2016 09:02:16 +0000
Message-ID: <BY2PR0201MB1784E3DB1AEDE9C007D92AA5BF4E0@BY2PR0201MB1784.namprd02.prod.outlook.com>
References: <CAL=_i_mcJoFnPgeU5FQCJN=SDYnNK7Jz8zoVMv9EMuWaGRYSMg@mail.gmail.com>,<BY2PR0201MB17843672AD6CE2C492793B98BF4E0@BY2PR0201MB1784.namprd02.prod.outlook.com>
In-Reply-To: <BY2PR0201MB17843672AD6CE2C492793B98BF4E0@BY2PR0201MB1784.namprd02.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
spamdiagnosticoutput: 1:23
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-originalarrivaltime: 23 May 2016 09:02:16.1405
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 32210298-c08b-4829-8097-6b12c025a892
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR0201MB1782
Subject: Re: [PHP-DEV] [RFC][Vote] Typed Properties
From: dmitry@zend.com (Dmitry Stogov)

I appreciate the work done by Joe, but I vote "no", because the implementat=
ion is not good enough yet

- it's incompatible with opcache (may be it's not a big problem to fix this=
)
- typed properties assignment is going to be 2-3 times slower ($obj->x +=3D=
 2; is 3 times slower)
- the patch makes slight negative effect even for untyped properties

- the proposed behavior for uninitialized typed properties assumes that the=
y have to be checked on each "read". This checks will have to be performed =
even in native JITed code. I don't see a reason for typing if we have to pe=
rform check on each read anyway.

Thanks. Dmitry.
________________________________________
From: Dmitry Stogov <dmitry@zend.com>
Sent: Monday, May 23, 2016 11:30:09 AM
To: Joe Watkins; PHP internals; Phil Sturgeon
Subject: Re: [PHP-DEV] [RFC][Vote] Typed Properties

Hi Joe,

The performance effect of this implementation is terrible.

Assignment to typed property is 2.3 times slower.
Assignment to untyped property in a class with typed properties is 1.8 time=
s slower.

See the benchmark
https://gist.github.com/dstogov/1b678712adeee51665cdd829195bb800

Thanks. Dmitry.
________________________________________
From: Joe Watkins <pthreads@pthreads.org>
Sent: Friday, May 20, 2016 9:05:34 AM
To: PHP internals; Phil Sturgeon
Subject: [PHP-DEV] [RFC][Vote] Typed Properties

Morning internals,

    Since we have our answer on nullable types, typed properties can now go
to vote.

    https://wiki.php.net/rfc/typed-properties#vote

    Note that, support for nullability as RFC'd will be merged when the
implementation for nullable_types is merged into master.

    Please participate.

Cheers
Joe

--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php