Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:93433
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain zend.com designates 65.55.169.104 as permitted sender)
To: Joe Watkins <pthreads@pthreads.org>, PHP internals
	<internals@lists.php.net>, Phil Sturgeon <pjsturgeon@gmail.com>
Thread-Topic: [PHP-DEV] [RFC][Vote] Typed Properties
Thread-Index: AQHRsl29xlQFrvOFJkSnB4pG0wOhsp/GLdHT
Date: Mon, 23 May 2016 08:04:03 +0000
Message-ID: <BY2PR0201MB178431CB73789C8B96CBFD04BF4E0@BY2PR0201MB1784.namprd02.prod.outlook.com>
References: <CAL=_i_mcJoFnPgeU5FQCJN=SDYnNK7Jz8zoVMv9EMuWaGRYSMg@mail.gmail.com>
In-Reply-To: <CAL=_i_mcJoFnPgeU5FQCJN=SDYnNK7Jz8zoVMv9EMuWaGRYSMg@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
spamdiagnosticoutput: 1:23
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-originalarrivaltime: 23 May 2016 08:04:03.6964
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 32210298-c08b-4829-8097-6b12c025a892
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR0201MB1784
Subject: Re: [PHP-DEV] [RFC][Vote] Typed Properties
From: dmitry@zend.com (Dmitry Stogov)

The patch "corrupts" opcache shared memory.
PHP crashes with opcache.protect_memory=3D1.

$ USE_ZEND_ALLOC=3D0 valgrind sapi/cli/php -d opcache.protect_memory=3D1 ..=
/Zend/tests/type_declarations/typed_properties_027.php
=3D=3D900=3D=3D Memcheck, a memory error detector
=3D=3D900=3D=3D Copyright (C) 2002-2015, and GNU GPL'd, by Julian Seward et=
 al.
=3D=3D900=3D=3D Using Valgrind-3.11.0 and LibVEX; rerun with -h for copyrig=
ht info
=3D=3D900=3D=3D Command: sapi/cli/php ../Zend/tests/type_declarations/typed=
_properties_027.php
=3D=3D900=3D=3D
=3D=3D900=3D=3D
=3D=3D900=3D=3D Process terminating with default action of signal 11 (SIGSE=
GV)
=3D=3D900=3D=3D  Bad permissions for mapped region at address 0xF00FFBC8
=3D=3D900=3D=3D    at 0x86391FE: zend_verify_weak_scalar_type_hint (zend_ex=
ecute.c:725)
=3D=3D900=3D=3D    by 0x8639833: zend_verify_scalar_property_type (zend_exe=
cute.c:869)
=3D=3D900=3D=3D    by 0x8639C2B: zend_verify_property_type (zend_execute.c:=
938)
=3D=3D900=3D=3D    by 0x862E46D: zend_std_write_property (zend_object_handl=
ers.c:753)
=3D=3D900=3D=3D    by 0x8685102: ZEND_ASSIGN_OBJ_SPEC_CV_CONST_OP_DATA_CONS=
T_HANDLER (zend_vm_execute.h:42160)
=3D=3D900=3D=3D    by 0x863F91D: execute_ex (zend_vm_execute.h:426)
=3D=3D900=3D=3D    by 0x863F9D2: zend_execute (zend_vm_execute.h:471)
=3D=3D900=3D=3D    by 0x85F38B4: zend_execute_scripts (zend.c:1427)
=3D=3D900=3D=3D    by 0x85832B7: php_execute_script (main.c:2492)
=3D=3D900=3D=3D    by 0x86AE2D8: do_cli (php_cli.c:982)
=3D=3D900=3D=3D    by 0x86AEF42: main (php_cli.c:1352)
=3D=3D900=3D=3D





________________________________________
From: Joe Watkins <pthreads@pthreads.org>
Sent: Friday, May 20, 2016 9:05:34 AM
To: PHP internals; Phil Sturgeon
Subject: [PHP-DEV] [RFC][Vote] Typed Properties

Morning internals,

    Since we have our answer on nullable types, typed properties can now go
to vote.

    https://wiki.php.net/rfc/typed-properties#vote

    Note that, support for nullability as RFC'd will be merged when the
implementation for nullable_types is merged into master.

    Please participate.

Cheers
Joe