Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:93432 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 42955 invoked from network); 23 May 2016 07:31:26 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 23 May 2016 07:31:26 -0000 Authentication-Results: pb1.pair.com header.from=me@kelunik.com; sender-id=unknown Authentication-Results: pb1.pair.com smtp.mail=me@kelunik.com; spf=permerror; sender-id=unknown Received-SPF: error (pb1.pair.com: domain kelunik.com from 81.169.146.218 cause and error) X-PHP-List-Original-Sender: me@kelunik.com X-Host-Fingerprint: 81.169.146.218 mo4-p00-ob.smtp.rzone.de Received: from [81.169.146.218] ([81.169.146.218:8568] helo=mo4-p00-ob.smtp.rzone.de) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 6C/A2-14293-CC1B2475 for ; Mon, 23 May 2016 03:31:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1463988682; l=3625; s=domk; d=kelunik.com; h=Content-Type:Cc:To:Subject:Date:From:In-Reply-To:References: MIME-Version; bh=qwRtxwsuI9rkkGqlWNKjUxLKGu4JqWFTm+EkDJ13jfQ=; b=QHFwN4n8IIuMFzmrX9J1YAm0DwB1y85mUeinQa5UjqrAqG9b5JnjzvFAr+98Ykm+PgD shGednwrs3nZWVBiGBf9QNVMGuZrLhJF5OHZOgWfQo9Mf2FBv02a7Jo8eKzj25tR1hwFL y5EPD5pMmSYkPr1BZcPHw/c+vPUZT2y/gpA= X-RZG-AUTH: :IWkkfkWkbvHsXQGmRYmUo9mls2vWuiu+7SLGvomb4bl9EfHtOnI6 X-RZG-CLASS-ID: mo00 Received: from mail-wm0-f51.google.com ([74.125.82.51]) by smtp.strato.de (RZmta 37.27 AUTH) with ESMTPSA id 6045des4N7VMY0P (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (curve secp384r1 with 384 ECDH bits, eq. 7680 bits RSA)) (Client did not present a certificate) for ; Mon, 23 May 2016 09:31:22 +0200 (CEST) Received: by mail-wm0-f51.google.com with SMTP id s131so769307wme.0 for ; Mon, 23 May 2016 00:31:22 -0700 (PDT) X-Gm-Message-State: AOPr4FWSvQhV9CgLhfDUArRsnIXUbmPNIbnss2h2WYvs+QDzX8TnlbuuW4wj3Dxhw3APP0nLPD+0kZ6y8+f/zw== X-Received: by 10.194.113.194 with SMTP id ja2mr14938487wjb.13.1463988682052; Mon, 23 May 2016 00:31:22 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: Date: Mon, 23 May 2016 07:31:12 +0000 X-Gmail-Original-Message-ID: Message-ID: To: Joe Watkins , Yasuo Ohgaki Cc: "internals@lists.php.net" , Davey Shafik Content-Type: multipart/alternative; boundary=001a1130cf145962f205337d6d65 Subject: Re: [PHP-DEV] base64_decode is buggy, what to fix? From: me@kelunik.com (Niklas Keller) --001a1130cf145962f205337d6d65 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Completely missing padding shouldn't fail, it's often removed to save space or when base64 is converted to base64url. Joe Watkins schrieb am Mo., 23. Mai 2016 06:59: > Morning, > > Would it be possible to open a PR that fixes the programming errors, > such as oob read, and the strange flow of the subsequent block ? > > Assuming those fixes don't effect normal usage, I see no reason why > that can't be merged immediately. > > When it comes to changing the behaviour, that needs a little more > discussion I think, and I wait to see what others think about those > changes. > > Cheers > Joe > > On Mon, May 23, 2016 at 1:52 AM, Yasuo Ohgaki wrote: > > > Hi Lauri, > > > > On Sun, May 22, 2016 at 7:56 PM, Lauri Kentt=C3=A4 > > wrote: > > > > > > Suggestions? > > > > IMHO > > > > Return FALSE for any invalid input when strict mode is on. > > Enable strict mode by default. > > Keep current behavior when strict mode is off. > > > > would be the best. > > > > Regards, > > > > -- > > Yasuo Ohgaki > > yohgaki@ohgaki.net > > > > -- > > PHP Internals - PHP Runtime Development Mailing List > > To unsubscribe, visit: http://www.php.net/unsub.php > > > > > --001a1130cf145962f205337d6d65--