Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:93431 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 35779 invoked from network); 23 May 2016 04:59:14 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 23 May 2016 04:59:14 -0000 Authentication-Results: pb1.pair.com smtp.mail=pthreads@pthreads.org; spf=permerror; sender-id=unknown Authentication-Results: pb1.pair.com header.from=pthreads@pthreads.org; sender-id=unknown Received-SPF: error (pb1.pair.com: domain pthreads.org from 209.85.161.181 cause and error) X-PHP-List-Original-Sender: pthreads@pthreads.org X-Host-Fingerprint: 209.85.161.181 mail-yw0-f181.google.com Received: from [209.85.161.181] ([209.85.161.181:36570] helo=mail-yw0-f181.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 2E/D1-14293-F1E82475 for ; Mon, 23 May 2016 00:59:12 -0400 Received: by mail-yw0-f181.google.com with SMTP id x189so160455245ywe.3 for ; Sun, 22 May 2016 21:59:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pthreads-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc; bh=GKFjEXA0oV30/cGu0kl3p0Z9y24bXLKlOTsgtlHxs48=; b=dC4XLaa3Jdu3mcaGUX3qCFdJ4G7nYefDHV3fGfHHNongZ5QNIP2wGYbhD3ERkbL5qx TY55ws6J/ugIIZI8Jp1rKyCJNzduogF3Xck23alTgW//DswTpkGVxmHP6tmisXvtvykr 1fm0D1YV+4/6fHNSZdulYA8A+3NzmeH4RFAcgSBGeS0kwsmy/BvcI2cMzplXn5QWmOji n7I7ifemLAPXakgnbKekBY+RVS1ZyUQyK3YMjm432Scw/FC7J75hD1cV69v4PKgflhON fuc3EewXuLD9LeJK6+ZI69JMHu3hANEAKNsYaFrtJQFRp/wuL571wFi04b6NYJGOUjAD kwkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc; bh=GKFjEXA0oV30/cGu0kl3p0Z9y24bXLKlOTsgtlHxs48=; b=SpFjEV8J3hIbdYvsppyy7/CDe0qZMw6LG0pXB1wzNamE5VD2XL5T+s+d7q6178RTqG keh3hFd46+irTKoFrzydX67YzqJXXWgwH1XErwBia3dM32mBMzpIBFeVcFw4y1+dO2cI dzod3zUBBhG+DVQeqF9ltJFXJtsBGnU4uU71Fsqxd5uUvDIWuWDOaeLTu5PP2JVvDMTS GwrXwGffzcLR87tJyR4G7VJD3l4s2hLrmYcF/thdSD5oCZ9LhBEc2az88nShXUtCXy2L g0g6ixJWxXB8ffNjRuXPJS5hpdpWY2WWVr5vmv+TYXhQl8lEJBeUUZHri6dkv7Dl/+mS HIxQ== X-Gm-Message-State: AOPr4FUYDrqMTLv80KIgqrMyf+OgrQfK8Yhe6xjzFqu9IVFdAhbevTPwesfZssPIKn/I4uy5pjQvzgUqQc1hNQ== MIME-Version: 1.0 X-Received: by 10.37.198.13 with SMTP id k13mr7793499ybf.127.1463979549091; Sun, 22 May 2016 21:59:09 -0700 (PDT) Received: by 10.129.109.67 with HTTP; Sun, 22 May 2016 21:59:09 -0700 (PDT) X-Originating-IP: [109.157.60.67] In-Reply-To: References: Date: Mon, 23 May 2016 05:59:09 +0100 Message-ID: To: Yasuo Ohgaki Cc: "internals@lists.php.net" , Davey Shafik Content-Type: multipart/alternative; boundary=94eb2c08cacefb985705337b4c6e Subject: Re: [PHP-DEV] base64_decode is buggy, what to fix? From: pthreads@pthreads.org (Joe Watkins) --94eb2c08cacefb985705337b4c6e Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Morning, Would it be possible to open a PR that fixes the programming errors, such as oob read, and the strange flow of the subsequent block ? Assuming those fixes don't effect normal usage, I see no reason why that can't be merged immediately. When it comes to changing the behaviour, that needs a little more discussion I think, and I wait to see what others think about those changes= . Cheers Joe On Mon, May 23, 2016 at 1:52 AM, Yasuo Ohgaki wrote: > Hi Lauri, > > On Sun, May 22, 2016 at 7:56 PM, Lauri Kentt=C3=A4 > wrote: > > > > Suggestions? > > IMHO > > Return FALSE for any invalid input when strict mode is on. > Enable strict mode by default. > Keep current behavior when strict mode is off. > > would be the best. > > Regards, > > -- > Yasuo Ohgaki > yohgaki@ohgaki.net > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php > > --94eb2c08cacefb985705337b4c6e--