Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:93425
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain mindplay.dk from 209.85.218.46 cause and error)
MIME-Version: 1.0
In-Reply-To: <fb93f245-a5e6-53f7-9fee-deaebb847b78@gmail.com>
References: <CADqTB_jC-EZ5p+c=q0dmRgaYAkyRVbdNFNUQRGhfaS7GaOTR9g@mail.gmail.com>
	<72f547d6-5fcf-3cd2-960d-cb612a429e47@php.net>
	<CANUQDCiEDeCV3RAr0bg+=-PHPDYkk-cP-ih4TnTGUzz7SNakMw@mail.gmail.com>
	<CADqTB_j67-ocNaWm5sRHbC4vJF2t7WBWUqrEXu9-Kk_MSi4CgA@mail.gmail.com>
	<CAF1yvAQozS1qpCbBNdAJu4gT5LbOEUimv2W-nWtkaUTbVZFubA@mail.gmail.com>
	<CANUQDCjnEgJwT5zEb50sWA5=OeF-LRzPDu_1+-E70as2N10oXw@mail.gmail.com>
	<fb93f245-a5e6-53f7-9fee-deaebb847b78@gmail.com>
Date: Sat, 21 May 2016 20:16:35 +0200
Message-ID: <CADqTB_inxTXkg+mVGyBVsP1drDqsWfaLMKe00R=veBQT7ZKedQ@mail.gmail.com>
To: Rowan Collins <rowan.collins@gmail.com>
Cc: PHP internals <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [PHP-DEV] Exception::getLine()
From: rasmus@mindplay.dk (Rasmus Schultz)

Alright, so forget my comparison with other languages.

My other points remain:

Presently, "throw new" is treated as though it was one statement.
That's not the case. We have deferred throws and factory methods for
exceptions, and we have re-throws, so collecting the stack-trace at
construction time doesn't work.

The construction site would only be relevant if "throw new" was in
deed a single statement.

Recording the actual throw site is clearly the goal - the current
implementation is betting on "throw" and "new" happening at the same
site, which is merely circumstance.

Ideally, an Exception should collect another stack trace for each
successive throw, which would enable you to trace not only the
original site, but the flow through any exception-handlers that might
have re-thrown the same Exception.

As is, there is no information collected on throw, and thereby no
evidence or record of possible re-throws - on top of the fact that you
may be collecting and looking at bogus stack-traces from factory
methods or exception mappers.


On Fri, May 20, 2016 at 11:06 AM, Rowan Collins <rowan.collins@gmail.com> wrote:
> On 20/05/2016 08:22, Niklas Keller wrote:
>>
>> 2016-05-20 4:13 GMT+02:00 Jesse Schalken <me@jesseschalken.com>:
>>>
>>> The top frame is the construction (get_error) and the site of the throw
>>> (do_throw) doesn't appear in the stack at all.
>>>
>>
>> The comparison with JavaScript isn't a good one, since you can throw
>> everything in JS. If they didn't provide the stack trace upon throw, you
>> would not have a stack trace at all if you throw a plain string.
>>
>
>
> That explanation justifies completely the opposite behaviour to what Jesse
> described.
>
> According to MDN [1] the "stack" property is completley unstandardised, and
> some engines may indeed populate it on throw, but there's no hint on that
> page that they'll attach it to anything not constructed as an Error.
>
> So it's not a great comparison for either side (note that it was originally
> brought up by Rasmus as an example where it *does* come from the throw site)
> because the language doesn't actually guarantee you a stack trace at all.
>
> [1]
> https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Error/stack
>
> Regards,
> --
> Rowan Collins
> [IMSoP]
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>